Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 23534041: Enable overview mode by default. (Closed)

Created:
7 years, 3 months ago by flackr
Modified:
7 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Enable overview mode by default. BUG=284891 TEST=Alt-tab and F5 button will enter overview mode without a flag. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221297

Patch Set 1 #

Total comments: 1

Patch Set 2 : Don't cycle with no windows. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -17 lines) Patch
M ash/accelerators/accelerator_controller.cc View 3 chunks +9 lines, -10 lines 0 comments Download
M ash/ash_switches.h View 2 chunks +1 line, -1 line 0 comments Download
M ash/ash_switches.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/overview/window_selector_controller.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
flackr
Enable overview mode by default. If not ready by the end of the milestone we ...
7 years, 3 months ago (2013-09-04 00:49:11 UTC) #1
sky
LGTM
7 years, 3 months ago (2013-09-04 14:27:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/23534041/1
7 years, 3 months ago (2013-09-04 16:34:49 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=151300
7 years, 3 months ago (2013-09-04 17:54:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/23534041/22001
7 years, 3 months ago (2013-09-04 20:46:57 UTC) #5
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=10937
7 years, 3 months ago (2013-09-04 21:17:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/23534041/22001
7 years, 3 months ago (2013-09-04 21:20:07 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 23:35:18 UTC) #8
Message was sent while issue was closed.
Change committed as 221297

Powered by Google App Engine
This is Rietveld 408576698