Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 23534024: createRange.... (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « samples/third_party/dromaeo/tests/dom-traverse-html.dart ('k') | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index f8d4ad49ba2c46d10e0a0322352cbbd8d6a4e3d9..acc55949606312f9df17475e1b787aef017085e2 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -7197,10 +7197,9 @@ class Document extends Node native "Document"
@Unstable()
NodeIterator _createNodeIterator(Node root, [int whatToShow, NodeFilter filter, bool expandEntityReferences]) native;
- @JSName('createRange')
@DomName('Document.createRange')
@DocsEditable()
- Range $dom_createRange() native;
+ Range createRange() native;
@JSName('createTextNode')
@DomName('Document.createTextNode')
@@ -9697,7 +9696,7 @@ abstract class Element extends Node implements ParentNode, ChildNode native "Ele
}
var fragment;
if (Range.supportsCreateContextualFragment) {
- var range = _parseDocument.$dom_createRange();
+ var range = _parseDocument.createRange();
range.selectNodeContents(contextElement);
fragment = range.createContextualFragment(html);
} else {
@@ -10166,12 +10165,12 @@ abstract class Element extends Node implements ParentNode, ChildNode native "Ele
@JSName('getAttribute')
@DomName('Element.getAttribute')
@DocsEditable()
- String $dom_getAttribute(String name) native;
+ String _getAttribute(String name) native;
@JSName('getAttributeNS')
@DomName('Element.getAttributeNS')
@DocsEditable()
- String $dom_getAttributeNS(String namespaceURI, String localName) native;
+ String _getAttributeNS(String namespaceURI, String localName) native;
@DomName('Element.getBoundingClientRect')
@DocsEditable()
@@ -10275,12 +10274,12 @@ abstract class Element extends Node implements ParentNode, ChildNode native "Ele
@JSName('setAttribute')
@DomName('Element.setAttribute')
@DocsEditable()
- void $dom_setAttribute(String name, String value) native;
+ void _setAttribute(String name, String value) native;
@JSName('setAttributeNS')
@DomName('Element.setAttributeNS')
@DocsEditable()
- void $dom_setAttributeNS(String namespaceURI, String qualifiedName, String value) native;
+ void _setAttributeNS(String namespaceURI, String qualifiedName, String value) native;
@JSName('webkitGetRegionFlowRanges')
@DomName('Element.webkitGetRegionFlowRanges')
@@ -17571,7 +17570,7 @@ class _ChildNodeListLazy extends ListBase<Node> {
_this._replaceChild(value, this[index]);
}
- Iterator<Node> get iterator => _this.$dom_childNodes.iterator;
+ Iterator<Node> get iterator => _this._childNodes.iterator;
// From List<Node>:
@@ -17593,15 +17592,15 @@ class _ChildNodeListLazy extends ListBase<Node> {
// -- end List<Node> mixins.
// TODO(jacobr): benchmark whether this is more efficient or whether caching
- // a local copy of $dom_childNodes is more efficient.
- int get length => _this.$dom_childNodes.length;
+ // a local copy of _childNodes is more efficient.
+ int get length => _this._childNodes.length;
void set length(int value) {
throw new UnsupportedError(
"Cannot set length on immutable List.");
}
- Node operator[](int index) => _this.$dom_childNodes[index];
+ Node operator[](int index) => _this._childNodes[index];
}
/** Information about the instantiated template. */
@@ -17800,7 +17799,7 @@ class Node extends EventTarget native "Node" {
@DocsEditable()
@Returns('NodeList')
@Creates('NodeList')
- final List<Node> $dom_childNodes;
+ final List<Node> _childNodes;
@DomName('Node.firstChild')
@DocsEditable()
@@ -19488,7 +19487,7 @@ typedef void RtcStatsCallback(RtcStatsResponse response);
@DomName('Range')
@Unstable()
class Range extends Interceptor native "Range" {
- factory Range() => document.$dom_createRange();
+ factory Range() => document.createRange();
factory Range.fromPoint(Point point) =>
document._caretRangeFromPoint(point.x, point.y);
@@ -27504,15 +27503,15 @@ class _ElementAttributeMap extends _AttributeMap {
}
String operator [](String key) {
- return _element.$dom_getAttribute(key);
+ return _element._getAttribute(key);
}
void operator []=(String key, String value) {
- _element.$dom_setAttribute(key, value);
+ _element._setAttribute(key, value);
}
String remove(String key) {
- String value = _element.$dom_getAttribute(key);
+ String value = _element._getAttribute(key);
_element._removeAttribute(key);
return value;
}
@@ -27541,11 +27540,11 @@ class _NamespacedAttributeMap extends _AttributeMap {
}
String operator [](String key) {
- return _element.$dom_getAttributeNS(_namespace, key);
+ return _element._getAttributeNS(_namespace, key);
}
void operator []=(String key, String value) {
- _element.$dom_setAttributeNS(_namespace, key, value);
+ _element._setAttributeNS(_namespace, key, value);
}
String remove(String key) {
« no previous file with comments | « samples/third_party/dromaeo/tests/dom-traverse-html.dart ('k') | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698