Added persistent capitalization to the Virtual Keyboard.

Added persistent capitalization to the Virtual Keyboard.

BUG=280147
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220628

[bshe, 2013-08-30 15:33:16]

lgtm with nits.

We may want to discuss offline today or next week. The more I think about it,
the more I feel that we should encapsulate all the logic into shift key. The two
attributes that you add to keyset looks like should managed by shift key.

https://codereview.chromium.org/23534021/diff/7001/ui/keyboard/resources/elem...
File ui/keyboard/resources/elements/kb-keyboard.html (right):

https://codereview.chromium.org/23534021/diff/7001/ui/keyboard/resources/elem...
ui/keyboard/resources/elements/kb-keyboard.html:204: // keyset.
Could you rephrase this comment? Not all keyboard has lower keyset.
Something like "If capslock is enabled and capsLockTo is not null, redirect to
keyset specified by capsLockTo" maybe better.

https://codereview.chromium.org/23534021/diff/7001/ui/keyboard/resources/elem...
ui/keyboard/resources/elements/kb-keyboard.html:205: if
(this.classList.contains('shift-locked') && keyset.shiftLocksTo)
Any particular reason not use caps-locked and capLockTo? It sounds easier to
understand.

[rsadam, 2013-08-30 15:50:07]

On 2013/08/30 15:33:16, bshe wrote:
> lgtm with nits.
> 
Renamed shift-locked to caps-locked (and similarly for the other variables), and
modified the comment as suggested.

In terms of the logic lets discuss it offline - I think we may have additional
difficulties if we move it to the shift key.

> We may want to discuss offline today or next week. The more I think about it,
> the more I feel that we should encapsulate all the logic into shift key. The
two
> attributes that you add to keyset looks like should managed by shift key.
> 
>
https://codereview.chromium.org/23534021/diff/7001/ui/keyboard/resources/elem...
> File ui/keyboard/resources/elements/kb-keyboard.html (right):
> 
>
https://codereview.chromium.org/23534021/diff/7001/ui/keyboard/resources/elem...
> ui/keyboard/resources/elements/kb-keyboard.html:204: // keyset.
> Could you rephrase this comment? Not all keyboard has lower keyset.
> Something like "If capslock is enabled and capsLockTo is not null, redirect to
> keyset specified by capsLockTo" maybe better.
> 
>
https://codereview.chromium.org/23534021/diff/7001/ui/keyboard/resources/elem...
> ui/keyboard/resources/elements/kb-keyboard.html:205: if
> (this.classList.contains('shift-locked') && keyset.shiftLocksTo)
> Any particular reason not use caps-locked and capLockTo? It sounds easier to
> understand.

[commit-bot: I haz the power, 2013-08-30 16:09:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsadam@chromium.org/23534021/11001

[commit-bot: I haz the power, 2013-08-30 19:26:14]

Change committed as 220628