Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 23534018: Increase maximum file descriptors per IPC message on POSIX from 5 to 7 (Closed)

Created:
7 years, 3 months ago by tommycli
Modified:
7 years, 3 months ago
Reviewers:
agl
CC:
chromium-reviews, vandebo (ex-Chrome), jam
Visibility:
Public.

Description

Increase maximum file descriptors per IPC message on POSIX from 5 to 7. On POSIX, the maximum number of file descriptors passable in an IPC message is controlled by a constant 'kMaxDescriptorsPerMessage'. It's currently set at 5. This patch makes it 7. The Picasa album table reader utility process (https://codereview.chromium.org/18986012/) needs to pass 7 files to the utility process. This works on Windows, but fails on POSIX (Mac), due to the aforementioned limit. This CL increases this limit to 7, as well as adds some DLOG messages to give better info to developers who hit this limit. ipc_channel_posix.cc seems to indicate adding extra file descriptors just makes the messages longer by an 'int' per file descriptor. Making the maximum even larger would be okay with me too. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220371

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M ipc/file_descriptor_set_posix.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/file_descriptor_set_posix.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tommycli
jam: Need OWNER review for ipc/.
7 years, 3 months ago (2013-08-29 01:16:57 UTC) #1
jam
please send this to an IPC owner that's more familiar with posix
7 years, 3 months ago (2013-08-29 05:04:44 UTC) #2
tommycli
agl: Need OWNER review
7 years, 3 months ago (2013-08-29 17:18:44 UTC) #3
tommycli
FYI: Last time it was increased was 2011: http://codereview.chromium.org/7010015
7 years, 3 months ago (2013-08-29 17:20:19 UTC) #4
agl
LGTM. The limit of 5 was set to be "crazy high". I shudder to think ...
7 years, 3 months ago (2013-08-29 17:22:34 UTC) #5
tommycli
On 2013/08/29 17:22:34, agl wrote: > LGTM. > > The limit of 5 was set ...
7 years, 3 months ago (2013-08-29 17:38:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/23534018/1
7 years, 3 months ago (2013-08-29 17:38:48 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-08-29 21:15:47 UTC) #8
Message was sent while issue was closed.
Change committed as 220371

Powered by Google App Engine
This is Rietveld 408576698