Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 23533047: Add spinner to the 'managed user import' overlay (Closed)

Created:
7 years, 3 months ago by ibra
Modified:
7 years, 3 months ago
Reviewers:
Bernhard Bauer, Sergiu
CC:
chromium-reviews, dbeam+watch-options_chromium.org, tfarina, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@choose_avatar_one_overlay
Visibility:
Public.

Description

Add spinner to the 'managed user import' overlay BUG=292418 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223404

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : sergiu@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M chrome/browser/resources/options/managed_user_import.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options/managed_user_import.js View 1 2 6 chunks +23 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
ibra
Hey Sergiu, please review, thanks!
7 years, 3 months ago (2013-09-12 13:21:19 UTC) #1
Sergiu
lgtm https://codereview.chromium.org/23533047/diff/4001/chrome/browser/resources/options/managed_user_import.js File chrome/browser/resources/options/managed_user_import.js (right): https://codereview.chromium.org/23533047/diff/4001/chrome/browser/resources/options/managed_user_import.js#newcode39 chrome/browser/resources/options/managed_user_import.js:39: var self = this; I'd move this just ...
7 years, 3 months ago (2013-09-16 08:46:04 UTC) #2
ibra
+ Bernhard, please take a look. Thanks! https://codereview.chromium.org/23533047/diff/4001/chrome/browser/resources/options/managed_user_import.js File chrome/browser/resources/options/managed_user_import.js (right): https://codereview.chromium.org/23533047/diff/4001/chrome/browser/resources/options/managed_user_import.js#newcode39 chrome/browser/resources/options/managed_user_import.js:39: var self ...
7 years, 3 months ago (2013-09-16 09:04:14 UTC) #3
Sergiu
On 2013/09/16 09:04:14, ibra wrote: > + Bernhard, please take a look. Thanks! > > ...
7 years, 3 months ago (2013-09-16 09:07:13 UTC) #4
Bernhard Bauer
lgtm
7 years, 3 months ago (2013-09-16 09:12:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ibraaaa@chromium.org/23533047/9001
7 years, 3 months ago (2013-09-16 17:37:40 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-16 17:46:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ibraaaa@chromium.org/23533047/9001
7 years, 3 months ago (2013-09-16 17:54:36 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-16 20:41:08 UTC) #9
Message was sent while issue was closed.
Change committed as 223404

Powered by Google App Engine
This is Rietveld 408576698