Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 23533042: Fixed issues found by fuzzer (Closed)

Created:
7 years, 3 months ago by sugoi1
Modified:
7 years, 3 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fixed issues found by fuzzer Last week, the fuzzer found a few numerical issue with filters and I had written some fixes for them. Here are the fixes with some unit tests. For senorblanco : So I figured out what was asserting when we'd get a 0 width "result" in SkBicubicImageFilter::onFilterImage(). Basically, if the "result" SkBitmap object calls SkBitmap::setConfig() with "width" and/or "height" set to 0, then the SkBitmap object will call SkBitmap::reset(), making the SkBitmap object's config invalid. At this point, calling SkBitmap::getAddr32() will assert, even without attempting to dereference the data pointer, because the SkBitmap's config is invalid. If height is valid, but width is 0, then this call to SkBitmap::getAddr32() happens directly in SkBicubicImageFilter::onFilterImage() a few lines lower and asserts right away. BUG= Committed: http://code.google.com/p/skia/source/detail?r=11249

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -9 lines) Patch
M include/effects/SkLightingImageFilter.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/SkBicubicImageFilter.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 5 chunks +16 lines, -8 lines 0 comments Download
M tests/ImageFilterTest.cpp View 2 chunks +73 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
sugoi1
7 years, 3 months ago (2013-09-06 18:38:17 UTC) #1
Stephen White
LGTM
7 years, 3 months ago (2013-09-09 17:47:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/23533042/1
7 years, 3 months ago (2013-09-10 13:39:55 UTC) #3
commit-bot: I haz the power
Presubmit check for 23533042-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 3 months ago (2013-09-10 13:39:59 UTC) #4
sugoi1
Adding bsalomon@ for approval.
7 years, 3 months ago (2013-09-10 13:42:43 UTC) #5
bsalomon
On 2013/09/10 13:42:43, sugoi1 wrote: > Adding bsalomon@ for approval. lgtm
7 years, 3 months ago (2013-09-10 13:46:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/23533042/1
7 years, 3 months ago (2013-09-10 13:53:35 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-13 12:40:07 UTC) #8
Message was sent while issue was closed.
Change committed as 11249

Powered by Google App Engine
This is Rietveld 408576698