Issue 23533041: Properly dismiss the InputDialogs in all cases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23533041: Properly dismiss the InputDialogs in all cases (Closed)

Created:
7 years, 3 months ago by Tiger

Modified:
7 years, 3 months ago

Reviewers:
keishi, Miguel Garcia, bulach

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Properly dismiss the InputDialogs in all cases On newer versions of Android, dismissing a date/time dialog (with hw back or touch outside of it) will still set the date or time. This is not the case on older Android versions. This fix adds an OnDismissListener that makes sure the dialog is always cancelled unless it already have been cancelled or already have reported back a new date. R=bulach@chromium.org,olilan@chromium.org,keishi@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222027