Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 23533039: Re-enables three WebRTC unit tests in content (Closed)

Created:
7 years, 3 months ago by henrika (OOO until Aug 14)
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Re-enables three WebRTC unit tests in content. It looks like some disabled unit tests could easily be enabled again just by extending the MockMediaInternals class. BUG=23533039 TEST=content_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221784

Patch Set 1 #

Patch Set 2 : nit #

Patch Set 3 : Disabled Android and improved tests for all other platforms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -36 lines) Patch
M content/browser/renderer_host/media/mock_media_observer.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/media/webrtc_audio_device_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/webrtc_audio_device_unittest.cc View 1 2 11 chunks +56 lines, -36 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
henrika (OOO until Aug 14)
Tommi, adding these tests will expand our test coverage and allow us to do more ...
7 years, 3 months ago (2013-09-05 10:24:56 UTC) #1
tommi (sloooow) - chröme
lgtm
7 years, 3 months ago (2013-09-05 13:12:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/23533039/8001
7 years, 3 months ago (2013-09-05 13:17:31 UTC) #3
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test on builder ...
7 years, 3 months ago (2013-09-05 19:28:41 UTC) #4
henrika (OOO until Aug 14)
My initial patch was flaky on Android so I disabled the added tests on Android ...
7 years, 3 months ago (2013-09-06 11:58:08 UTC) #5
no longer working on chromium
On 2013/09/06 11:58:08, henrika wrote: > My initial patch was flaky on Android so I ...
7 years, 3 months ago (2013-09-06 12:07:39 UTC) #6
tommi (sloooow) - chröme
lgtm
7 years, 3 months ago (2013-09-06 12:52:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/23533039/35001
7 years, 3 months ago (2013-09-06 13:01:02 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 21:22:00 UTC) #9
Message was sent while issue was closed.
Change committed as 221784

Powered by Google App Engine
This is Rietveld 408576698