Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 23533032: Added policy to control pref: spdy_proxy.enabled (kSpdyProxyAuthEnabled). (Closed)

Created:
7 years, 3 months ago by bolian
Modified:
7 years, 3 months ago
Reviewers:
Joao da Silva
CC:
chromium-reviews, joaodasilva+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Added policy to control pref: spdy_proxy.enabled (kSpdyProxyAuthEnabled). BUG=273830 This enables admins to turn the data compression proxy feature off through cloud policy. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222009

Patch Set 1 #

Patch Set 2 : updated id. #

Total comments: 2

Patch Set 3 : Changed based on Joao's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M chrome/app/policy/policy_templates.json View 1 2 chunks +19 lines, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Joao da Silva
Hey Bolian! This looks quite alright, just a little nit to fix. I'm not sure ...
7 years, 3 months ago (2013-09-05 09:49:20 UTC) #1
bolian
(I did send out for official review before as I was not sure if this ...
7 years, 3 months ago (2013-09-05 17:36:51 UTC) #2
Joao da Silva
lgtm!
7 years, 3 months ago (2013-09-09 10:03:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bolian@chromium.org/23533032/8001
7 years, 3 months ago (2013-09-09 10:03:18 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 12:13:52 UTC) #5
Message was sent while issue was closed.
Change committed as 222009

Powered by Google App Engine
This is Rietveld 408576698