Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 23533012: Representation of interceptor / handler properties are tagged. (Closed)

Created:
6 years, 3 months ago by Toon Verwaest
Modified:
6 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Representation of interceptor / handler properties are tagged. Otherwise store ICs will never be initialized, due to lookup->CanHoldValue(value); BUG=chromium:256330 R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16471

Patch Set 1 #

Patch Set 2 : Adding test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M src/property.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL
6 years, 3 months ago (2013-09-02 11:47:58 UTC) #1
Jakob Kummerow
LGTM. Can we have a testcase (that asserts that a function doesn't deopt when optimized ...
6 years, 3 months ago (2013-09-02 11:51:26 UTC) #2
Jakob Kummerow
Thanks! LGTM.
6 years, 3 months ago (2013-09-02 12:12:32 UTC) #3
Toon Verwaest
6 years, 3 months ago (2013-09-02 12:16:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r16471 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698