Issue 23533012: Representation of interceptor / handler properties are tagged.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23533012: Representation of interceptor / handler properties are tagged. (Closed)

Created:
7 years, 3 months ago by Toon Verwaest

Modified:
7 years, 3 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Representation of interceptor / handler properties are tagged. Otherwise store ICs will never be initialized, due to lookup->CanHoldValue(value); BUG=chromium:256330 R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16471

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -2 lines)			Patch
	M	src/property.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	test/cctest/test-api.cc	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Jakob Kummerow

LGTM. Can we have a testcase (that asserts that a function doesn't deopt when optimized ...

7 years, 3 months ago (2013-09-02 11:51:26 UTC) #2

Toon Verwaest

7 years, 3 months ago (2013-09-02 12:16:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r16471 (presubmit successful).