Issue 23532073: Only showing the new multi user menus when there are at least 2 suitable users known to the system

Issue 23532073: Only showing the new multi user menus when there are at least 2 suitable users known to the system (Closed)

Created:
7 years, 3 months ago by Mr4D (OOO till 08-26)

Modified:
7 years, 3 months ago

Reviewers:
James Cook, sail

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Only showing the new multi user menus when there are at least 2 suitable users known to the system For the new multi login mode (ChromeOS) we only want to show the Multilogin UI when there are at least 2 suitable users known to the system (and the commandline is properly set). BUG=291154 TEST=visual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223367

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -6 lines)			Patch
	M	chrome/browser/profiles/avatar_menu_model.cc	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
	M	chrome/browser/ui/ash/chrome_shell_delegate.cc	View		2 chunks	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

sail

https://codereview.chromium.org/23532073/diff/1/chrome/browser/profiles/avatar_menu_model.cc File chrome/browser/profiles/avatar_menu_model.cc (right): https://codereview.chromium.org/23532073/diff/1/chrome/browser/profiles/avatar_menu_model.cc#newcode46 chrome/browser/profiles/avatar_menu_model.cc:46: #if defined(OS_CHROMEOS) Shouldn't use ifdefs. A simple way to ...

7 years, 3 months ago (2013-09-13 23:57:30 UTC) #2

James Cook

https://codereview.chromium.org/23532073/diff/1/chrome/browser/profiles/avatar_menu_model.cc File chrome/browser/profiles/avatar_menu_model.cc (right): https://codereview.chromium.org/23532073/diff/1/chrome/browser/profiles/avatar_menu_model.cc#newcode280 chrome/browser/profiles/avatar_menu_model.cc:280: chromeos::UserManager::Get()->GetLoggedInUsers().size() <= 1; Should this be <= 1 or ...

7 years, 3 months ago (2013-09-14 00:03:14 UTC) #3

Mr4D (OOO till 08-26)

Addressed. Please have another look! https://codereview.chromium.org/23532073/diff/1/chrome/browser/profiles/avatar_menu_model.cc File chrome/browser/profiles/avatar_menu_model.cc (right): https://codereview.chromium.org/23532073/diff/1/chrome/browser/profiles/avatar_menu_model.cc#newcode46 chrome/browser/profiles/avatar_menu_model.cc:46: #if defined(OS_CHROMEOS) Okay, I ...

7 years, 3 months ago (2013-09-14 17:16:28 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/23532073/7001

7 years, 3 months ago (2013-09-16 16:02:40 UTC) #7

Message was sent while issue was closed.

Change committed as 223367

Expand Messages | Collapse Messages