policy: Add ostream operator overloads to policy types for testing.

policy: Add ostream operator overloads to policy types for testing.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221472

[dconnelly, 2013-09-03 13:37:38]

It isn't pretty, but it's readable.  Looking for suggestions.
For example:

PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa):
{bool: PolicyMap::Entry(1, 0, true
)
dict: PolicyMap::Entry(1, 0, {
   "bool": true,
   "double": 123.456,
   "int": 789,
   "list": [ {
      "subdict": {
         "bool": true,
         "double": 123.456,
         "int": 789,
         "str": "string value"
      },
      "subdictindex": 0
   }, {
      "subdict": {
         "bool": true,
         "double": 123.456,
         "int": 789,
         "str": "string value"
      },
      "subdictindex": 1
   } ],
   "str": "string value"
}
)
double: PolicyMap::Entry(1, 0, 123.456
)
int: PolicyMap::Entry(1, 0, 789
)
list: PolicyMap::Entry(1, 0, [ {
   "subdict": {
      "bool": true,
      "double": 123.456,
      "int": 789,
      "str": "string value"
   },
   "subdictindex": 0
}, {
   "subdict": {
      "bool": true,
      "double": 123.456,
      "int": 789,
      "str": "string value"
   },
   "subdictindex": 1
} ]
)
str: PolicyMap::Entry(1, 0, "string value"
)
}

[Mattias Nissler (ping if slow), 2013-09-03 15:31:50]

Maybe it'd make sense to instead generate proper JSON? That way, we have a
format that's both easily readable to both machines and humans.

https://codereview.chromium.org/23532033/diff/1/chrome/browser/policy/test_ut...
File chrome/browser/policy/test_utils.cc (right):

https://codereview.chromium.org/23532033/diff/1/chrome/browser/policy/test_ut...
chrome/browser/policy/test_utils.cc:51: os << "POLICY_DOMAIN_UNKNOWN";
would probably be better to log the numerical value here.

https://codereview.chromium.org/23532033/diff/1/chrome/browser/policy/test_ut...
File chrome/browser/policy/test_utils.h (right):

https://codereview.chromium.org/23532033/diff/1/chrome/browser/policy/test_ut...
chrome/browser/policy/test_utils.h:1: // Copyright (c) 2013 The Chromium
Authors. All rights reserved.
Note that this file only gets linked into browser_tests, you probably want to
move it over to test_support_common or similar.

[dconnelly, 2013-09-04 17:43:02]

Now generates json.  Example:

{
  "POLICY_DOMAIN_CHROME/": {
  "DictionaryPolicy": {
  "level": POLICY_LEVEL_MANDATORY,
  "scope": POLICY_SCOPE_MACHINE,
  "value": {
   "bool": true,
   "dict": {
      "bool": true,
      "double": 123.456,
      "int": 789,
      "list": [ {
         "subdict": {
            "bool": true,
            "double": 123.456,
            "int": 789,
            "str": "string value"
         },
         "subdictindex": 0
      }, {
         "subdict": {
            "bool": true,
            "double": 123.456,
            "int": 789,
            "str": "string value"
         },
         "subdictindex": 1
      } ],
      "str": "string value"
   },
   "double": 123.456,
   "int": 789,
   "list": [ {
      "subdict": {
         "bool": true,
         "double": 123.456,
         "int": 789,
         "str": "string value"
      },
      "subdictindex": 0
   }, {
      "subdict": {
         "bool": true,
         "double": 123.456,
         "int": 789,
         "str": "string value"
      },
      "subdictindex": 1
   } ],
   "str": "string value"
}
},
},
  "POLICY_DOMAIN_EXTENSIONS/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa": {
  "bool": {
  "level": POLICY_LEVEL_MANDATORY,
  "scope": POLICY_SCOPE_MACHINE,
  "value": true
},
  "dict": {
  "level": POLICY_LEVEL_MANDATORY,
  "scope": POLICY_SCOPE_MACHINE,
  "value": {
   "bool": true,
   "double": 123.456,
   "int": 789,
   "list": [ {

... etc

https://codereview.chromium.org/23532033/diff/1/chrome/browser/policy/test_ut...
File chrome/browser/policy/test_utils.cc (right):

https://codereview.chromium.org/23532033/diff/1/chrome/browser/policy/test_ut...
chrome/browser/policy/test_utils.cc:51: os << "POLICY_DOMAIN_UNKNOWN";
On 2013/09/03 15:31:50, Mattias Nissler wrote:
> would probably be better to log the numerical value here.

Done.

https://codereview.chromium.org/23532033/diff/1/chrome/browser/policy/test_ut...
File chrome/browser/policy/test_utils.h (right):

https://codereview.chromium.org/23532033/diff/1/chrome/browser/policy/test_ut...
chrome/browser/policy/test_utils.h:1: // Copyright (c) 2013 The Chromium
Authors. All rights reserved.
On 2013/09/03 15:31:50, Mattias Nissler wrote:
> Note that this file only gets linked into browser_tests, you probably want to
> move it over to test_support_common or similar.

Done.

[Mattias Nissler (ping if slow), 2013-09-05 12:29:47]

I think this is good enough now, so LGTM. It might be more flexible to instead
provide helpers to convert to base::Value* representation instead (and rely on
base::Value's ostream operator), but I don't have good arguments to justify that
right now.

[commit-bot: I haz the power, 2013-09-05 12:31:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dconnelly@chromium.org/23532033/6001

[commit-bot: I haz the power, 2013-09-05 18:35:30]

Change committed as 221472