Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: test/css_test.dart

Issue 23532024: Changes in webui to comply with the safe html changes. Now that Nodes can be (Closed) Base URL: git@github.com:dart-lang/web-ui.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pubspec.yaml ('k') | test/data/expected/escape3_test.html.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/css_test.dart
diff --git a/test/css_test.dart b/test/css_test.dart
index 758145d362f1db4a5b5824ad46408756f2e53352..d23d143f2ea151b845598dfd80f0715d4aa51b38 100644
--- a/test/css_test.dart
+++ b/test/css_test.dart
@@ -410,61 +410,64 @@ test_component_var() {
// Check for warning messages about var- cycles.
expect(messages.messages.length, 8);
- var errorMessage = messages.messages[0];
+ var sortedMessages = messages.messages;
+ sortedMessages.sort((m1, m2) => m1.message.compareTo(m2.message));
+
+ var errorMessage = sortedMessages[0];
expect(errorMessage.message, contains('var cycle detected var-def-1'));
expect(errorMessage.span, isNotNull);
expect(errorMessage.span.start.line, 11);
expect(errorMessage.span.start.column, 22);
expect(errorMessage.span.text, '@def-1: var(def-2)');
- errorMessage = messages.messages[1];
- expect(errorMessage.message, contains('var cycle detected var-five'));
- expect(errorMessage.span, isNotNull);
- expect(errorMessage.span.start.line, 8);
- expect(errorMessage.span.start.column, 22);
- expect(errorMessage.span.text, '@five: var(six)');
-
- errorMessage = messages.messages[2];
- expect(errorMessage.message, contains('var cycle detected var-six'));
+ errorMessage = sortedMessages[1];
+ expect(errorMessage.message, contains('var cycle detected var-def-2'));
expect(errorMessage.span, isNotNull);
- expect(errorMessage.span.start.line, 9);
+ expect(errorMessage.span.start.line, 12);
expect(errorMessage.span.start.column, 22);
- expect(errorMessage.span.text, '@six: var(four)');
+ expect(errorMessage.span.text, '@def-2: var(def-3)');
- errorMessage = messages.messages[3];
+ errorMessage = sortedMessages[2];
expect(errorMessage.message, contains('var cycle detected var-def-3'));
expect(errorMessage.span, isNotNull);
expect(errorMessage.span.start.line, 13);
expect(errorMessage.span.start.column, 22);
expect(errorMessage.span.text, '@def-3: var(def-2)');
- errorMessage = messages.messages[4];
- expect(errorMessage.message, contains('var cycle detected var-two'));
+ errorMessage = sortedMessages[3];
+ expect(errorMessage.message, contains('var cycle detected var-five'));
expect(errorMessage.span, isNotNull);
- expect(errorMessage.span.start.line, 5);
+ expect(errorMessage.span.start.line, 8);
expect(errorMessage.span.start.column, 22);
- expect(errorMessage.span.text, '@two: var(one)');
+ expect(errorMessage.span.text, '@five: var(six)');
- errorMessage = messages.messages[5];
- expect(errorMessage.message, contains('var cycle detected var-def-2'));
+ errorMessage = sortedMessages[4];
+ expect(errorMessage.message, contains('var cycle detected var-four'));
expect(errorMessage.span, isNotNull);
- expect(errorMessage.span.start.line, 12);
+ expect(errorMessage.span.start.line, 7);
expect(errorMessage.span.start.column, 22);
- expect(errorMessage.span.text, '@def-2: var(def-3)');
+ expect(errorMessage.span.text, '@four: var(five)');
- errorMessage = messages.messages[6];
+ errorMessage = sortedMessages[5];
expect(errorMessage.message, contains('var cycle detected var-one'));
expect(errorMessage.span, isNotNull);
expect(errorMessage.span.start.line, 4);
expect(errorMessage.span.start.column, 22);
expect(errorMessage.span.text, '@one: var(two)');
- errorMessage = messages.messages[7];
- expect(errorMessage.message, contains('var cycle detected var-four'));
+ errorMessage = sortedMessages[6];
+ expect(errorMessage.message, contains('var cycle detected var-six'));
expect(errorMessage.span, isNotNull);
- expect(errorMessage.span.start.line, 7);
+ expect(errorMessage.span.start.line, 9);
expect(errorMessage.span.start.column, 22);
- expect(errorMessage.span.text, '@four: var(five)');
+ expect(errorMessage.span.text, '@six: var(four)');
+
+ errorMessage = sortedMessages[7];
+ expect(errorMessage.message, contains('var cycle detected var-two'));
+ expect(errorMessage.span, isNotNull);
+ expect(errorMessage.span.start.line, 5);
+ expect(errorMessage.span.start.column, 22);
+ expect(errorMessage.span.text, '@two: var(one)');
}));
});
}
« no previous file with comments | « pubspec.yaml ('k') | test/data/expected/escape3_test.html.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698