Chromium Code Reviews
Help | Chromium Project | Sign in
(641)

Issue 23532024: Changes in webui to comply with the safe html changes. Now that Nodes can be (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by Siggi Cherem (dart-lang)
Modified:
2 years ago
Reviewers:
John Messerly, blois
CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/web-ui.git@master
Visibility:
Public.

Description

Changes in webui for SDK 0.7.0. Two general changes were needed: - changes to comply with the safe html changes. Now that Nodes can be created safely, I also allow injecting them in bindings directly. - changes in tests that relied on the order of iteration of sets (this seemed to have changed too) R=blois@google.com Committed: https://github.com/dart-lang/web-ui/commit/2650dbf

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -61 lines) Patch
M lib/safe_html.dart View 1 1 chunk +8 lines, -1 line 0 comments Download
M lib/src/emitters.dart View 2 chunks +33 lines, -11 lines 0 comments Download
M lib/templating.dart View 2 chunks +40 lines, -8 lines 0 comments Download
M pubspec.yaml View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M test/css_test.dart View 1 chunk +29 lines, -26 lines 0 comments Download
A + test/data/expected/escape3_test.html.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/data/input/escape3_test.html View 2 chunks +5 lines, -6 lines 0 comments Download
M test/observe_test.dart View 2 chunks +8 lines, -8 lines 0 comments Download
Trybot results:
Project "None" does not have a commit queue.

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
2 years ago (2013-08-31 00:13:10 UTC) #1
blois
lgtm
2 years ago (2013-08-31 00:18:20 UTC) #2
Siggi Cherem (dart-lang)
2 years ago (2013-08-31 00:22:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r2650dbf (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 020f378