Issue 23532024: Changes in webui to comply with the safe html changes. Now that Nodes can be

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 23532024: Changes in webui to comply with the safe html changes. Now that Nodes can be (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
3 years, 10 months ago by Siggi Cherem (dart-lang)

Modified:
3 years, 10 months ago

Reviewers:
Jennifer Messerly, blois

CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/web-ui.git@master

Visibility:
Public.

More Reviews

Description

Changes in webui for SDK 0.7.0. Two general changes were needed: - changes to comply with the safe html changes. Now that Nodes can be created safely, I also allow injecting them in bindings directly. - changes in tests that relied on the order of iteration of sets (this seemed to have changed too) R=blois@google.com Committed: https://github.com/dart-lang/web-ui/commit/2650dbf

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -61 lines)			Patch
M	lib/safe_html.dart	View	1	1 chunk	+8 lines, -1 line	0 comments	Download
M	lib/src/emitters.dart	View		2 chunks	+33 lines, -11 lines	0 comments	Download
M	lib/templating.dart	View		2 chunks	+40 lines, -8 lines	0 comments	Download
M	pubspec.yaml	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/css_test.dart	View		1 chunk	+29 lines, -26 lines	0 comments	Download
A +	test/data/expected/escape3_test.html.txt	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/data/input/escape3_test.html	View		2 chunks	+5 lines, -6 lines	0 comments	Download
M	test/observe_test.dart	View		2 chunks	+8 lines, -8 lines	0 comments	Download

Trybot results:

Commit queue not available (can’t edit this change).

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

3 years, 10 months ago (2013-08-31 00:22:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r2650dbf (presubmit successful).

Expand Messages | Collapse Messages