Issue 23532018: Files.app: Extract the TextMeasure class to a new file.

Issue 23532018: Files.app: Extract the TextMeasure class to a new file. (Closed)

Created:
7 years, 3 months ago by hirono

Modified:
7 years, 3 months ago

Reviewers:
yoshiki

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Files.app: Extract the TextMeasure class to a new file. Currently it is in file_manager.js file, which is huge. BUG=282198 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220589

Patch Set 1 : Rebased #

Total comments: 2

Patch Set 2 : Addressed the comment. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -44 lines)			Patch
M	chrome/browser/resources/file_manager/js/file_manager.js	View		1 chunk	+0 lines, -44 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/main_scripts.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/browser/resources/file_manager/js/text_measure.js	View	1	1 chunk	+50 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/main.html	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

yoshiki

lgtm with nit https://codereview.chromium.org/23532018/diff/4001/chrome/browser/resources/file_manager/js/text_measure.js File chrome/browser/resources/file_manager/js/text_measure.js (right): https://codereview.chromium.org/23532018/diff/4001/chrome/browser/resources/file_manager/js/text_measure.js#newcode36 chrome/browser/resources/file_manager/js/text_measure.js:36: } Can you add 'Object.seal(this);'?

7 years, 3 months ago (2013-08-30 10:41:40 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/23532018/11001

7 years, 3 months ago (2013-08-30 11:45:51 UTC) #3

hirono

Thanks! https://codereview.chromium.org/23532018/diff/4001/chrome/browser/resources/file_manager/js/text_measure.js File chrome/browser/resources/file_manager/js/text_measure.js (right): https://codereview.chromium.org/23532018/diff/4001/chrome/browser/resources/file_manager/js/text_measure.js#newcode36 chrome/browser/resources/file_manager/js/text_measure.js:36: } On 2013/08/30 10:41:40, yoshiki wrote: > Can ...

7 years, 3 months ago (2013-08-30 11:46:01 UTC) #4

Message was sent while issue was closed.

Change committed as 220589

Expand Messages | Collapse Messages