Issue 23532015: Fix scroll_delta computation on windows for vertical scroll by page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23532015: Fix scroll_delta computation on windows for vertical scroll by page (Closed)

Created:
7 years, 3 months ago by jamesr

Modified:
7 years, 3 months ago

Reviewers:
darin (slow to review), sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix scroll_delta computation on windows for vertical scroll by page When scrolling by page, we just need to set scrollByPage to true. Multiplying the scroll_delta by pixelsPerLine results in scrolling much too far. BUG=279035 TEST=manually tested following steps on the bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220536