Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 23531033: Fixing various problems with the new shelf layout in conjunction with the blue tray background on b… (Closed)

Created:
7 years, 3 months ago by Mr4D (OOO till 08-26)
Modified:
7 years, 3 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Fixing various problems with the new shelf layout in conjunction with the blue tray background on bubble activation There was a mismatch between the hover animation & the activation state. I cleaned up the activation code, removed the old override functions, and added comments on various places which had none yet. BUG=274105 TEST=visual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221597

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -50 lines) Patch
M ash/system/tray/system_tray.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/system/tray/system_tray.cc View 3 chunks +11 lines, -10 lines 0 comments Download
M ash/system/tray/tray_background_view.h View 1 3 chunks +14 lines, -7 lines 0 comments Download
M ash/system/tray/tray_background_view.cc View 7 chunks +16 lines, -23 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mr4D (OOO till 08-26)
Please have a look!
7 years, 3 months ago (2013-09-04 21:55:41 UTC) #1
Harry McCleave
On 2013/09/04 21:55:41, Mr4D wrote: > Please have a look! lgtm, ty for help /w ...
7 years, 3 months ago (2013-09-04 22:50:14 UTC) #2
jennyz
lgtm with minor nit. https://codereview.chromium.org/23531033/diff/1/ash/system/tray/tray_background_view.h File ash/system/tray/tray_background_view.h (right): https://codereview.chromium.org/23531033/diff/1/ash/system/tray/tray_background_view.h#newcode175 ash/system/tray/tray_background_view.h:175: // background differently if set ...
7 years, 3 months ago (2013-09-05 18:29:21 UTC) #3
Mr4D (OOO till 08-26)
Addressed! Thanks! https://codereview.chromium.org/23531033/diff/1/ash/system/tray/tray_background_view.h File ash/system/tray/tray_background_view.h (right): https://codereview.chromium.org/23531033/diff/1/ash/system/tray/tray_background_view.h#newcode175 ash/system/tray/tray_background_view.h:175: // background differently if set to true. ...
7 years, 3 months ago (2013-09-05 18:46:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/23531033/7001
7 years, 3 months ago (2013-09-05 18:47:02 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 06:09:23 UTC) #6
Message was sent while issue was closed.
Change committed as 221597

Powered by Google App Engine
This is Rietveld 408576698