Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: content/browser/devtools/renderer_overrides_handler.cc

Issue 23531017: DevTools: pass offset top and bottom for screencast viewport. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/devtools/devtools_protocol_constants.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/devtools/renderer_overrides_handler.h" 5 #include "content/browser/devtools/renderer_overrides_handler.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/base64.h" 9 #include "base/base64.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 407 matching lines...) Expand 10 before | Expand all | Expand 10 after
418 418
419 base::DictionaryValue* response = new base::DictionaryValue(); 419 base::DictionaryValue* response = new base::DictionaryValue();
420 response->SetString(devtools::Page::kData, base_64_data); 420 response->SetString(devtools::Page::kData, base_64_data);
421 421
422 // Consider metadata empty in case it has no device scale factor. 422 // Consider metadata empty in case it has no device scale factor.
423 if (metadata.device_scale_factor != 0) { 423 if (metadata.device_scale_factor != 0) {
424 response->SetDouble(devtools::Page::kParamDeviceScaleFactor, 424 response->SetDouble(devtools::Page::kParamDeviceScaleFactor,
425 metadata.device_scale_factor); 425 metadata.device_scale_factor);
426 response->SetDouble(devtools::Page::kParamPageScaleFactor, 426 response->SetDouble(devtools::Page::kParamPageScaleFactor,
427 metadata.page_scale_factor); 427 metadata.page_scale_factor);
428 response->SetDouble(devtools::Page::kParamOffsetTop,
429 metadata.location_bar_content_translation.y());
430 response->SetDouble(devtools::Page::kParamOffsetBottom,
431 metadata.overdraw_bottom_height);
428 432
429 base::DictionaryValue* viewport = new base::DictionaryValue(); 433 base::DictionaryValue* viewport = new base::DictionaryValue();
430 viewport->SetDouble(devtools::kParamX, metadata.root_scroll_offset.x()); 434 viewport->SetDouble(devtools::kParamX, metadata.root_scroll_offset.x());
431 viewport->SetDouble(devtools::kParamY, metadata.root_scroll_offset.y()); 435 viewport->SetDouble(devtools::kParamY, metadata.root_scroll_offset.y());
432 viewport->SetDouble(devtools::kParamWidth, metadata.viewport_size.width()); 436 viewport->SetDouble(devtools::kParamWidth, metadata.viewport_size.width());
433 viewport->SetDouble(devtools::kParamHeight, 437 viewport->SetDouble(devtools::kParamHeight,
434 metadata.viewport_size.height()); 438 metadata.viewport_size.height());
435 response->Set(devtools::Page::kParamViewport, viewport); 439 response->Set(devtools::Page::kParamViewport, viewport);
436 } 440 }
437 441
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
581 return NULL; 585 return NULL;
582 } 586 }
583 event.data.pinchUpdate.scale = static_cast<float>(scale); 587 event.data.pinchUpdate.scale = static_cast<float>(scale);
584 } 588 }
585 589
586 host->ForwardGestureEvent(event); 590 host->ForwardGestureEvent(event);
587 return command->SuccessResponse(NULL); 591 return command->SuccessResponse(NULL);
588 } 592 }
589 593
590 } // namespace content 594 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/devtools/devtools_protocol_constants.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698