Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: Source/wtf/PassOwnArrayPtr.h

Issue 23531003: Type check when upcasting PassOwnPtr/PassOwnArrayPtr to avoid possible function call ambiguousness (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/wtf/OwnPtr.h ('k') | Source/wtf/PassOwnPtr.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 public: 42 public:
43 typedef T* PtrType; 43 typedef T* PtrType;
44 44
45 PassOwnArrayPtr() : m_ptr(0) { } 45 PassOwnArrayPtr() : m_ptr(0) { }
46 PassOwnArrayPtr(std::nullptr_t) : m_ptr(0) { } 46 PassOwnArrayPtr(std::nullptr_t) : m_ptr(0) { }
47 47
48 // It somewhat breaks the type system to allow transfer of ownership out of 48 // It somewhat breaks the type system to allow transfer of ownership out of
49 // a const PassOwnArrayPtr. However, it makes it much easier to work with Pa ssOwnArrayPtr 49 // a const PassOwnArrayPtr. However, it makes it much easier to work with Pa ssOwnArrayPtr
50 // temporaries, and we don't have a need to use real const PassOwnArrayPtrs anyway. 50 // temporaries, and we don't have a need to use real const PassOwnArrayPtrs anyway.
51 PassOwnArrayPtr(const PassOwnArrayPtr& o) : m_ptr(o.leakPtr()) { } 51 PassOwnArrayPtr(const PassOwnArrayPtr& o) : m_ptr(o.leakPtr()) { }
52 template<typename U> PassOwnArrayPtr(const PassOwnArrayPtr<U>& o) : m_ptr(o. leakPtr()) { } 52 template<typename U> PassOwnArrayPtr(const PassOwnArrayPtr<U>& o, EnsurePtrC onvertibleArgDecl(U, T)) : m_ptr(o.leakPtr()) { }
53 53
54 ~PassOwnArrayPtr() { deleteOwnedArrayPtr(m_ptr); } 54 ~PassOwnArrayPtr() { deleteOwnedArrayPtr(m_ptr); }
55 55
56 PtrType get() const { return m_ptr; } 56 PtrType get() const { return m_ptr; }
57 57
58 PtrType leakPtr() const WARN_UNUSED_RETURN; 58 PtrType leakPtr() const WARN_UNUSED_RETURN;
59 59
60 T& operator*() const { ASSERT(m_ptr); return *m_ptr; } 60 T& operator*() const { ASSERT(m_ptr); return *m_ptr; }
61 PtrType operator->() const { ASSERT(m_ptr); return m_ptr; } 61 PtrType operator->() const { ASSERT(m_ptr); return m_ptr; }
62 62
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 } 161 }
162 162
163 } // namespace WTF 163 } // namespace WTF
164 164
165 using WTF::PassOwnArrayPtr; 165 using WTF::PassOwnArrayPtr;
166 using WTF::adoptArrayPtr; 166 using WTF::adoptArrayPtr;
167 using WTF::const_pointer_cast; 167 using WTF::const_pointer_cast;
168 using WTF::static_pointer_cast; 168 using WTF::static_pointer_cast;
169 169
170 #endif // WTF_PassOwnArrayPtr_h 170 #endif // WTF_PassOwnArrayPtr_h
OLDNEW
« no previous file with comments | « Source/wtf/OwnPtr.h ('k') | Source/wtf/PassOwnPtr.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698