Chromium Code Reviews Chromium Code Reviews
Issue
23530019:
Remove new dialog style command-line flags, etc. (Closed)
DescriptionRemove new dialog style command-line flags, etc.
Remove --[en|dis]able-new-dialog-style command-line flags.
Remove the corresponding strings and about:flags entry.
The new dialog style has been on-by-default since M-29.
Retain DialogDelegate::UseNewStyle() for Views/Win Textfield.
(new dialogs can't host the off-by-default Win Textfields)
(this will go away once I remove the Views Textfield flags)
Retain split DialogDelegate::UseNewStyleForThisDialog() codepaths.
(we explicitly want the old style for some dialogs see Issue 246777)
(task manager, about:ipc dialog, extension (cros save/open) dialog)
(this could go away if we made those windows not use dialog code)
BUG=166075, 282698
TEST=New dialog style is used on Windows/CrOS everywhere except for the Task Manager, about:ipc dialog (Win only), and Extension (CrOS save/open) dialogs. The old dialog style is used with --disable-views-textfields for technical reasons.
R=sky@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221292
Patch Set 1 #Patch Set 2 : Remove strings; tweak comment. #
Messages
Total messages: 4 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
