Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23530007: Move API flows for cloud print into common class CloudPrintBaseApiFlow (Closed)

Created:
7 years, 3 months ago by Noam Samuel
Modified:
7 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Move API flows for cloud print into common class CloudPrintBaseApiFlow extracted common functionality from CloudPrintAccountManager and PrivetApiCallFlow into a common class CloudPrintBaseApiFlow. BUG=286157 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221600

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Total comments: 2

Patch Set 6 : AppendQueryParameter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -223 lines) Patch
M chrome/browser/local_discovery/cloud_print_account_manager.h View 2 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/local_discovery/cloud_print_account_manager.cc View 1 3 chunks +19 lines, -36 lines 0 comments Download
A chrome/browser/local_discovery/cloud_print_base_api_flow.h View 1 2 3 4 5 1 chunk +97 lines, -0 lines 0 comments Download
A + chrome/browser/local_discovery/cloud_print_base_api_flow.cc View 1 2 3 4 5 6 chunks +51 lines, -35 lines 0 comments Download
M chrome/browser/local_discovery/privet_confirm_api_flow.h View 2 chunks +15 lines, -35 lines 0 comments Download
M chrome/browser/local_discovery/privet_confirm_api_flow.cc View 3 chunks +22 lines, -93 lines 0 comments Download
M chrome/browser/local_discovery/privet_confirm_api_flow_unittest.cc View 9 chunks +21 lines, -10 lines 0 comments Download
M chrome/browser/local_discovery/privet_constants.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.h View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc View 1 2 3 4 5 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Noam Samuel
7 years, 3 months ago (2013-08-29 23:34:42 UTC) #1
Noam Samuel
7 years, 3 months ago (2013-09-04 20:42:44 UTC) #2
Vitaly Buka (NO REVIEWS)
BUG? https://chromiumcodereview.appspot.com/23530007/diff/5009/chrome/browser/local_discovery/cloud_print_base_api_flow.cc File chrome/browser/local_discovery/cloud_print_base_api_flow.cc (right): https://chromiumcodereview.appspot.com/23530007/diff/5009/chrome/browser/local_discovery/cloud_print_base_api_flow.cc#newcode150 chrome/browser/local_discovery/cloud_print_base_api_flow.cc:150: if (!value.get() || !value->GetAsDictionary(&dictionary_value)) { no need .get()
7 years, 3 months ago (2013-09-04 21:38:32 UTC) #3
Noam Samuel
https://chromiumcodereview.appspot.com/23530007/diff/5009/chrome/browser/local_discovery/cloud_print_base_api_flow.cc File chrome/browser/local_discovery/cloud_print_base_api_flow.cc (right): https://chromiumcodereview.appspot.com/23530007/diff/5009/chrome/browser/local_discovery/cloud_print_base_api_flow.cc#newcode150 chrome/browser/local_discovery/cloud_print_base_api_flow.cc:150: if (!value.get() || !value->GetAsDictionary(&dictionary_value)) { On 2013/09/04 21:38:32, Vitaly ...
7 years, 3 months ago (2013-09-04 23:45:06 UTC) #4
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/23530007/diff/20001/chrome/browser/local_discovery/cloud_print_base_api_flow.cc File chrome/browser/local_discovery/cloud_print_base_api_flow.cc (right): https://codereview.chromium.org/23530007/diff/20001/chrome/browser/local_discovery/cloud_print_base_api_flow.cc#newcode72 chrome/browser/local_discovery/cloud_print_base_api_flow.cc:72: url_.spec().c_str(), net::AppendQueryParameter
7 years, 3 months ago (2013-09-05 01:08:33 UTC) #5
Noam Samuel
https://codereview.chromium.org/23530007/diff/20001/chrome/browser/local_discovery/cloud_print_base_api_flow.cc File chrome/browser/local_discovery/cloud_print_base_api_flow.cc (right): https://codereview.chromium.org/23530007/diff/20001/chrome/browser/local_discovery/cloud_print_base_api_flow.cc#newcode72 chrome/browser/local_discovery/cloud_print_base_api_flow.cc:72: url_.spec().c_str(), On 2013/09/05 01:08:33, Vitaly Buka wrote: > net::AppendQueryParameter ...
7 years, 3 months ago (2013-09-05 23:22:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/23530007/27001
7 years, 3 months ago (2013-09-06 01:08:48 UTC) #7
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 3 months ago (2013-09-06 06:09:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/23530007/27001
7 years, 3 months ago (2013-09-06 06:10:56 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 06:13:21 UTC) #10
Message was sent while issue was closed. 
Change committed as 221600

Powered by Google App Engine
This is Rietveld 408576698