[CSS Grid Layout] Update named grid lines syntax to the last version of the specs

Source/core/css/CSSGrammar.y.in

 /*
  *  Copyright (C) 2002-2003 Lars Knoll (knoll@kde.org)
  *  Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  *  Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *  Copyright (C) 2008 Eric Seidel <eric@webkit.org>
  *  Copyright (C) 2012 Intel Corporation. All rights reserved.
  *
  *  This library is free software; you can redistribute it and/or
  *  modify it under the terms of the GNU Lesser General Public
  *  License as published by the Free Software Foundation; either
@@ skipping 78 matching lines @@
 
 inline static CSSParserValue makeOperatorValue(int value)
 {
     CSSParserValue v;
     v.id = CSSValueInvalid;
     v.unit = CSSParserValue::Operator;
     v.iValue = value;
     return v;
 }
 
+inline static CSSParserValue makeIdentValue(CSSParserString string)
+{
+    CSSParserValue v;
+    v.id = cssValueKeywordID(string);
+    v.unit = CSSPrimitiveValue::CSS_IDENT;
+    v.string = string;
+    return v;
+}
+
 %}
 
 %expect 0
 
 %nonassoc LOWEST_PREC
 
 %left UNIMPORTANT_TOK
 
 %token WHITESPACE SGML_CD
 %token TOKEN_EOF 0
@@ skipping 213 matching lines @@
 %type <valueList> calc_func_paren_expr
 %type <value> calc_function
 %type <string> min_or_max
 %type <value> min_or_max_function
 
 %type <string> element_name
 %type <string> attr_name
 
 %type <location> error_location
 
+%type <valueList> ident_list
+%type <valueList> track_names_list
+
 %%
 
 stylesheet:
     maybe_charset maybe_sgml rule_list
   | internal_decls
   | internal_rule
   | internal_selector
   | internal_value
   | internal_medialist
   | internal_keyframe_rule
@@ skipping 1285 matching lines @@
         if ($$ == CSSPropertyInvalid)
             parser->reportError($1, CSSParser::InvalidPropertyError);
     }
   ;
 
 prio:
     IMPORTANT_SYM maybe_space { $$ = true; }
     | /* empty */ { $$ = false; }
   ;
 
+ident_list:
+    IDENT maybe_space {
+        $$ = parser->createFloatingValueList();
+        $$->addValue(makeIdentValue($1));
+    }
+    | ident_list IDENT maybe_space {
+        $$ = $1;
+        $$->addValue(makeIdentValue($2));
+    }
+    ;
+
+track_names_list:
+    '(' maybe_space ident_list closing_parenthesis maybe_space {
+        $$ = $3;
+        $$->insertValueAt(0, makeOperatorValue('('));

[Julien - ping for review, 2013/11/12 07:33:17]

I wonder if we couldn't simplify the code by making inserting the value list
directly: it seems dumb to lose the already split list of <ident> (not to
mention the shenanigans we do to reconstruct the consumed operators so that we
split it _again_ in CSSParser-in.cpp).

[svillar, 2013/11/12 07:45:04]

I can take a look again, and maybe the changes proposed by rune would make it
better, but the reason behind adding the operators is to allow the parser to
distinguish between track names and other types of indents. As I explained in my
first comment

    10px (trackname) max-content

the parser needs to know that the list of indents between parenthesis are track
names and the other indents are track breadths.

[Julien - ping for review, 2013/11/12 07:49:38]

Agreed but the proposal was to insert the list as-is: track breadths would
inserted as CSSPrimitiveValue(s) one at a time where track names would be stored
in a nested CSSValueList. This should make it possible to differentiate them in
CSSParser-in.cpp.

+        $$->addValue(makeOperatorValue(')'));
+    }
+  ;
+
 expr:
     term {
         $$ = parser->createFloatingValueList();
         $$->addValue(parser->sinkFloatingValue($1));
     }
+    | track_names_list {
+        $$ = $1;
+    }
+    | expr track_names_list {
+        $$ = $1;
+        $$->extend(*($2));

[rune, 2013/09/10 11:30:19]

$2, which comes from is createFloatingValueList() in the ident_list production,
is not kept after this statement. There's no "sink", which means ident_lists
will be added to m_floatValueLists while parsing, but never deleted until the
CSSParser object is deleted.

+    }
     | expr operator term {
         $$ = $1;
         $$->addValue(makeOperatorValue($2));
         $$->addValue(parser->sinkFloatingValue($3));
     }
+    | expr operator track_names_list {
+        $$ = $1;
+        $$->addValue(makeOperatorValue($2));
+        $$->extend(*($3));
+    }
     | expr term {
         $$ = $1;
         $$->addValue(parser->sinkFloatingValue($2));
     }
   ;
 
 expr_recovery:
     error error_location error_recovery {
         parser->reportError($2, CSSParser::PropertyDeclarationError);
     }
   ;
 
 operator:
     '/' maybe_space {
         $$ = '/';
     }
   | ',' maybe_space {
         $$ = ',';
     }
   ;
 
 term:
   unary_term maybe_space
   | unary_operator unary_term maybe_space { $$ = $2; $$.fValue *= $1; }
   | STRING maybe_space { $$.id = CSSValueInvalid; $$.string = $1; $$.unit = CSSPrimitiveValue::CSS_STRING; }
-  | IDENT maybe_space {
-      $$.id = cssValueKeywordID($1);
-      $$.unit = CSSPrimitiveValue::CSS_IDENT;
-      $$.string = $1;
-  }
+  | IDENT maybe_space { $$ = makeIdentValue($1); }
   /* We might need to actually parse the number from a dimension, but we can't just put something that uses $$.string into unary_term. */
   | DIMEN maybe_space { $$.id = CSSValueInvalid; $$.string = $1; $$.unit = CSSPrimitiveValue::CSS_DIMENSION; }
   | unary_operator DIMEN maybe_space { $$.id = CSSValueInvalid; $$.string = $2; $$.unit = CSSPrimitiveValue::CSS_DIMENSION; }
   | URI maybe_space { $$.id = CSSValueInvalid; $$.string = $1; $$.unit = CSSPrimitiveValue::CSS_URI; }
   | UNICODERANGE maybe_space { $$.id = CSSValueInvalid; $$.string = $1; $$.unit = CSSPrimitiveValue::CSS_UNICODE_RANGE; }
   | HEX maybe_space { $$.id = CSSValueInvalid; $$.string = $1; $$.unit = CSSPrimitiveValue::CSS_PARSER_HEXCOLOR; }
   | '#' maybe_space { $$.id = CSSValueInvalid; $$.string = CSSParserString(); $$.unit = CSSPrimitiveValue::CSS_PARSER_HEXCOLOR; } /* Handle error case: "color: #;" */
   | VARFUNCTION maybe_space IDENT closing_parenthesis maybe_space {
       $$.id = CSSValueInvalid;
       $$.string = $3;
@@ skipping 227 matching lines @@
 
 rule_error_recovery:
     /* empty */
   | rule_error_recovery error
   | rule_error_recovery invalid_square_brackets_block
   | rule_error_recovery invalid_parentheses_block
     ;
 
 %%