Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 23526053: rAc: fix suggestion text line height on Views. (Closed)

Created:
7 years, 3 months ago by Evan Stade
Modified:
7 years, 3 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, benquan, tfarina, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

rAc: fix suggestion text line height on Views. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223649

Patch Set 1 #

Patch Set 2 : remove cruft #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Stade
makes the inter-line spacing match the mocks (this came up as a pain point in ...
7 years, 3 months ago (2013-09-17 01:53:08 UTC) #1
groby-ooo-7-16
Assuming the magic numbers are straight from the mock? LGTM
7 years, 3 months ago (2013-09-17 11:39:04 UTC) #2
Evan Stade
On 2013/09/17 11:39:04, groby wrote: > Assuming the magic numbers are straight from the mock? ...
7 years, 3 months ago (2013-09-17 15:17:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/23526053/5001
7 years, 3 months ago (2013-09-17 15:18:15 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 18:55:15 UTC) #5
Message was sent while issue was closed.
Change committed as 223649

Powered by Google App Engine
This is Rietveld 408576698