Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 23526030: [ash] Update applist button status when applist is hiding by outside event of applist button (Closed)

Created:
7 years, 3 months ago by simonhong_
Modified:
7 years, 3 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, hyojun.im_lge.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[ash] Update applist button status when applist is hiding by outside event of applist button. R=harrym@chromium.org BUG=277740 TEST=Compiles, Visual test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222215

Patch Set 1 #

Patch Set 2 : Makes change applist button status when applist visiblity is changed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ash/wm/app_list_controller.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
simonhong_
Dear jamescook, Please take a look.
7 years, 3 months ago (2013-09-09 01:28:08 UTC) #1
simonhong_
Dear harrym, I noticed that you already have this issue. Would you review this cl ...
7 years, 3 months ago (2013-09-09 22:11:10 UTC) #2
Harry McCleave
On 2013/09/09 22:11:10, Simon YoungKi Hong wrote: > Dear harrym, > I noticed that you ...
7 years, 3 months ago (2013-09-09 22:31:02 UTC) #3
simonhong_
On 2013/09/09 22:31:02, Harry McCleave wrote: > On 2013/09/09 22:11:10, Simon YoungKi Hong wrote: > ...
7 years, 3 months ago (2013-09-09 23:53:42 UTC) #4
Harry McCleave
On 2013/09/09 23:53:42, Simon YoungKi Hong wrote: > On 2013/09/09 22:31:02, Harry McCleave wrote: > ...
7 years, 3 months ago (2013-09-10 00:31:39 UTC) #5
simonhong_
Dear jamescook, I need owners check.
7 years, 3 months ago (2013-09-10 00:34:48 UTC) #6
James Cook
lgtm
7 years, 3 months ago (2013-09-10 00:54:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/23526030/5001
7 years, 3 months ago (2013-09-10 00:55:15 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-10 01:26:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/23526030/5001
7 years, 3 months ago (2013-09-10 01:40:15 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-10 01:51:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/23526030/5001
7 years, 3 months ago (2013-09-10 05:52:45 UTC) #12
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 08:37:56 UTC) #13
Message was sent while issue was closed.
Change committed as 222215

Powered by Google App Engine
This is Rietveld 408576698