Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 23526025: Add test for getting different InputMethodContext for different elements. (Closed)

Created:
7 years, 3 months ago by kochi
Modified:
7 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Add test for getting different InputMethodContext for different elements. BUG=none TEST=layouttest fast/ime Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157439

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update for comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M LayoutTests/fast/ime/html-getinputcontext.html View 1 2 chunks +6 lines, -0 lines 0 comments Download
M LayoutTests/fast/ime/html-getinputcontext-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kochi
tkent-san, Could you review?
7 years, 3 months ago (2013-09-06 09:36:41 UTC) #1
kochi
On 2013/09/06 09:36:41, Takayoshi Kochi wrote: > tkent-san, > > Could you review? BTW, I'm ...
7 years, 3 months ago (2013-09-06 09:43:08 UTC) #2
tkent
https://codereview.chromium.org/23526025/diff/1/LayoutTests/fast/ime/html-getinputcontext.html File LayoutTests/fast/ime/html-getinputcontext.html (right): https://codereview.chromium.org/23526025/diff/1/LayoutTests/fast/ime/html-getinputcontext.html#newcode32 LayoutTests/fast/ime/html-getinputcontext.html:32: shouldBeTrue('input != input2'); Do you mean shouldNotBe('input.inputMethodContext', 'input2.inputMethodContext) ?
7 years, 3 months ago (2013-09-09 00:29:19 UTC) #3
tkent
On 2013/09/06 09:43:08, Takayoshi Kochi wrote: > BTW, I'm not sure what caused a space ...
7 years, 3 months ago (2013-09-09 00:29:53 UTC) #4
kochi
On 2013/09/09 00:29:53, tkent wrote: > On 2013/09/06 09:43:08, Takayoshi Kochi wrote: > > BTW, ...
7 years, 3 months ago (2013-09-09 04:27:01 UTC) #5
kochi
PTAL. https://codereview.chromium.org/23526025/diff/1/LayoutTests/fast/ime/html-getinputcontext.html File LayoutTests/fast/ime/html-getinputcontext.html (right): https://codereview.chromium.org/23526025/diff/1/LayoutTests/fast/ime/html-getinputcontext.html#newcode32 LayoutTests/fast/ime/html-getinputcontext.html:32: shouldBeTrue('input != input2'); On 2013/09/09 00:29:19, tkent wrote: ...
7 years, 3 months ago (2013-09-09 05:07:18 UTC) #6
tkent
lgtm
7 years, 3 months ago (2013-09-09 05:09:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/23526025/16001
7 years, 3 months ago (2013-09-09 05:11:07 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 06:28:42 UTC) #9
Message was sent while issue was closed.
Change committed as 157439

Powered by Google App Engine
This is Rietveld 408576698