Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 23526021: rAc: reduce number of redundant layouts of DetailsContainerView (Closed)

Created:
7 years, 3 months ago by Evan Stade
Modified:
7 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, benquan, tfarina, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

rAc: reduce number of redundant layouts of DetailsContainerView This cuts down total AutofillDialogViews layout time by about half (!). BUG=285996, 272402 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221584

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -20 lines) Patch
M chrome/browser/ui/views/autofill/autofill_dialog_views.h View 2 chunks +25 lines, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 3 chunks +24 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Stade
see first bug for more context.
7 years, 3 months ago (2013-09-05 22:07:14 UTC) #1
sky
Ugh. LGTM
7 years, 3 months ago (2013-09-05 23:40:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/23526021/1
7 years, 3 months ago (2013-09-06 00:49:04 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 05:38:27 UTC) #4
Message was sent while issue was closed.
Change committed as 221584

Powered by Google App Engine
This is Rietveld 408576698