Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 23526014: Remove incorrect const qualifier from resize(). (Closed)

Created:
7 years, 3 months ago by Tom Hudson
Modified:
7 years, 3 months ago
Reviewers:
brettw, Nico, tomhudson
CC:
chromium-reviews, erikwright+watch_chromium.org, danakj
Visibility:
Public.

Description

Remove incorrect const qualifier from resize(). ScopedPtrHashMap<>::resize() failed to compile because it's a strict constness violation. Removing the const qualifier works. BUG=283892 R=brettw@chromium.org,thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221241

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/containers/scoped_ptr_hash_map.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tomhudson
Brett, Nico, please suggest somebody else if one of you isn't an appropriate reviewer; I've ...
7 years, 3 months ago (2013-09-04 13:24:57 UTC) #1
Nico
lgtm
7 years, 3 months ago (2013-09-04 15:44:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tomhudson@chromium.org/23526014/1
7 years, 3 months ago (2013-09-04 16:34:26 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 20:01:05 UTC) #4
Message was sent while issue was closed.
Change committed as 221241

Powered by Google App Engine
This is Rietveld 408576698