Issue 23526005: Enhance Sync Node Browser Logging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23526005: Enhance Sync Node Browser Logging (Closed)

Created:
7 years, 3 months ago by Pete Williamson

Modified:
7 years, 3 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org, albertb+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enhance Sync Node Browser Logging When we added the logging before, due to time constraints we didn't log everything that we were using. Now that we have a bit more time, I've added more logging to help as we enter the bug fix phase for Synced Notifications. This logging should help with specific outstanding bugs as well as being generally useful moving forwards. BUG=281510 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220424

Patch Set 1 #

Patch Set 2 : First patch set bad, try a second one. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -0 lines)			Patch
	M	sync/protocol/proto_value_conversions.h	View		4 chunks	+13 lines, -0 lines	0 comments	Download
	M	sync/protocol/proto_value_conversions.cc	View		3 chunks	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nicolas Zea

could you upload a new patchset? looks like the old one didn't upload properly

7 years, 3 months ago (2013-08-29 20:04:32 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petewil@chromium.org/23526005/9001

7 years, 3 months ago (2013-08-29 20:31:10 UTC) #5

Message was sent while issue was closed.

Change committed as 220424

Expand Messages | Collapse Messages