Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 23523056: Add support for chromium.googlesource.com/a/chromium... to the CQ. (Closed)

Created:
7 years, 3 months ago by M-A Ruel
Modified:
7 years, 3 months ago
Reviewers:
iannucci
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/commit-queue@master
Visibility:
Public.

Description

Add support for chromium.googlesource.com/a/chromium... to the CQ. I fetch occasionally directly from there. R=iannucci@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=222960

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M projects.py View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/project_test.py View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
7 years, 3 months ago (2013-09-12 20:33:41 UTC) #1
M-A Ruel
Switching to Robbie since Isaac is probably sleeping at the moment.
7 years, 3 months ago (2013-09-12 22:10:36 UTC) #2
iannucci
lgtm https://codereview.chromium.org/23523056/diff/1/tests/project_test.py File tests/project_test.py (right): https://codereview.chromium.org/23523056/diff/1/tests/project_test.py#newcode215 tests/project_test.py:215: 'tools\\/([a-z0-9\\-_]+)(?:\\.git)?' + branch, blaaarrrrr regex!!!
7 years, 3 months ago (2013-09-13 00:42:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/23523056/1
7 years, 3 months ago (2013-09-13 02:15:28 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-13 02:16:07 UTC) #5
Message was sent while issue was closed.
Change committed as 222960

Powered by Google App Engine
This is Rietveld 408576698