Issue 23523056: Add support for chromium.googlesource.com/a/chromium... to the CQ.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23523056: Add support for chromium.googlesource.com/a/chromium... to the CQ. (Closed)

Created:
7 years, 3 months ago by M-A Ruel

Modified:
7 years, 3 months ago

Reviewers:
iannucci

CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/commit-queue@master

Visibility:
Public.

More Reviews

Description

Add support for chromium.googlesource.com/a/chromium... to the CQ. I fetch occasionally directly from there. R=iannucci@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=222960

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	projects.py	View		2 chunks	+2 lines, -0 lines	0 comments	Download
	M	tests/project_test.py	View		1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Switching to Robbie since Isaac is probably sleeping at the moment.

7 years, 3 months ago (2013-09-12 22:10:36 UTC) #2

iannucci

lgtm https://codereview.chromium.org/23523056/diff/1/tests/project_test.py File tests/project_test.py (right): https://codereview.chromium.org/23523056/diff/1/tests/project_test.py#newcode215 tests/project_test.py:215: 'tools\\/([a-z0-9\\-_]+)(?:\\.git)?' + branch, blaaarrrrr regex!!!

7 years, 3 months ago (2013-09-13 00:42:46 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/23523056/1

7 years, 3 months ago (2013-09-13 02:15:28 UTC) #4

Message was sent while issue was closed.

Change committed as 222960

Expand Messages | Collapse Messages