Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 23523033: Fix Chrome crash when opening feedback in incognito. (Closed)

Created:
7 years, 3 months ago by rkc
Modified:
7 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Fix Chrome crash when opening feedback in incognito. R=asargent@chromium.org BUG=285413 TEST=Launching feedback in Incognito/Guest mode works and the browser doesn't crash. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221864

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/extensions/api/feedback_private/feedback_private_api.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rkc
7 years, 3 months ago (2013-09-06 23:07:26 UTC) #1
asargent_no_longer_on_chrome
Do you already have some browser tests for this API? If so it would be ...
7 years, 3 months ago (2013-09-06 23:11:51 UTC) #2
rkc
On 2013/09/06 23:11:51, Antony Sargent wrote: > Do you already have some browser tests for ...
7 years, 3 months ago (2013-09-06 23:13:27 UTC) #3
asargent_no_longer_on_chrome
ok, lgtm
7 years, 3 months ago (2013-09-06 23:24:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/23523033/1
7 years, 3 months ago (2013-09-06 23:25:57 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-07 02:36:41 UTC) #6
Message was sent while issue was closed.
Change committed as 221864

Powered by Google App Engine
This is Rietveld 408576698