Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 23523026: Use ThreadNow() for recording times. (Closed)

Created:
7 years, 3 months ago by dsinclair
Modified:
7 years, 3 months ago
Reviewers:
nduca, ernstm
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Use ThreadNow() for recording times. If available, this CL changes RenderingStatsInstrumentation to use ThreadNow() instead of HighResNow(). ThreadNow should provide a more accurate benchmark as it will exclude time when the thread is descheduled. BUG=280638 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221591

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M cc/debug/rendering_stats_instrumentation.cc View 1 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dsinclair
ernstm, nduca, PTAL.
7 years, 3 months ago (2013-09-05 14:11:59 UTC) #1
ernstm
LGTM
7 years, 3 months ago (2013-09-05 17:52:55 UTC) #2
nduca
lgtm
7 years, 3 months ago (2013-09-05 19:52:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/23523026/3001
7 years, 3 months ago (2013-09-05 19:55:23 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 05:51:47 UTC) #5
Message was sent while issue was closed.
Change committed as 221591

Powered by Google App Engine
This is Rietveld 408576698