Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issue 23523025: [Android] SelectPopupDialog - resolve style for <select> dialogs. (Closed)

Created:
7 years, 3 months ago by Primiano Tucci (use gerrit)
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[Android] SelectPopupDialog - resolve style for <select> dialogs. Right now the <select> dialogs use directly R.layout.select_dialog_(multi|single)choice defined in the Android framework. Adding an extra level of indirection to them through attrs since other builds need to override these two layouts. BUG=285270 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221396

Patch Set 1 #

Total comments: 6

Patch Set 2 : Nits (retested, works fine.) #

Total comments: 2

Patch Set 3 : Nits (isMultiChoice) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M content/public/android/java/res/values-v17/styles.xml View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/android/java/res/values/attrs.xml View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/android/java/resource_map/org/chromium/content/R.java View 1 2 chunks +3 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java View 1 2 5 chunks +18 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Primiano Tucci (use gerrit)
7 years, 3 months ago (2013-09-04 16:13:38 UTC) #1
benm (inactive)
thanks primiano! https://codereview.chromium.org/23523025/diff/1/content/public/android/java/res/values/attrs.xml File content/public/android/java/res/values/attrs.xml (right): https://codereview.chromium.org/23523025/diff/1/content/public/android/java/res/values/attrs.xml#newcode11 content/public/android/java/res/values/attrs.xml:11: <attr name="select_dialog_singlechoice" format="reference" /> nit, alphabetical order ...
7 years, 3 months ago (2013-09-04 16:43:02 UTC) #2
Primiano Tucci (use gerrit)
https://codereview.chromium.org/23523025/diff/1/content/public/android/java/res/values/attrs.xml File content/public/android/java/res/values/attrs.xml (right): https://codereview.chromium.org/23523025/diff/1/content/public/android/java/res/values/attrs.xml#newcode11 content/public/android/java/res/values/attrs.xml:11: <attr name="select_dialog_singlechoice" format="reference" /> On 2013/09/04 16:43:02, benm wrote: ...
7 years, 3 months ago (2013-09-04 17:03:47 UTC) #3
benm (inactive)
lgtm
7 years, 3 months ago (2013-09-04 17:26:54 UTC) #4
benm (inactive)
+joth ptal too
7 years, 3 months ago (2013-09-04 20:57:03 UTC) #5
joth
lgtm
7 years, 3 months ago (2013-09-04 21:01:03 UTC) #6
newt (away)
lgtm https://codereview.chromium.org/23523025/diff/7001/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java File content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java (right): https://codereview.chromium.org/23523025/diff/7001/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java#newcode108 content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java:108: private int getSelectDialogLayout(boolean multiple) { nit: I'd name ...
7 years, 3 months ago (2013-09-04 23:39:22 UTC) #7
Primiano Tucci (use gerrit)
Cool! Thanks all for the review. https://codereview.chromium.org/23523025/diff/7001/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java File content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java (right): https://codereview.chromium.org/23523025/diff/7001/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java#newcode108 content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java:108: private int getSelectDialogLayout(boolean ...
7 years, 3 months ago (2013-09-05 11:51:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/23523025/15001
7 years, 3 months ago (2013-09-05 13:00:19 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 13:05:31 UTC) #10
Message was sent while issue was closed.
Change committed as 221396

Powered by Google App Engine
This is Rietveld 408576698