Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: chrome/browser/ui/views/tabs/tab_drag_controller.h

Issue 23523018: Fixes use after free during drag and drop. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge 2 trunk Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tabs/tab_drag_controller.h
diff --git a/chrome/browser/ui/views/tabs/tab_drag_controller.h b/chrome/browser/ui/views/tabs/tab_drag_controller.h
index 9dc0bb2bc4ee4b67813726a56c0a7779e8eae3eb..afb67a239a6a431297f7b1e285208b163c6f3a47 100644
--- a/chrome/browser/ui/views/tabs/tab_drag_controller.h
+++ b/chrome/browser/ui/views/tabs/tab_drag_controller.h
@@ -535,10 +535,10 @@ class TabDragController : public content::WebContentsDelegate,
// attached to the hidden frame and the frame moved back to these bounds.
gfx::Rect restore_bounds_;
- // The last view that had focus in the window containing |source_tab_|. This
- // is saved so that focus can be restored properly when a drag begins and
- // ends within this same window.
- views::View* old_focused_view_;
+ // ID of the last view that had focus in the window containing
+ // |source_tab_|. This is saved so that focus can be restored properly when a
+ // drag begins and ends within this same window.
+ const int old_focused_view_id_;
// The position along the major axis of the mouse cursor in screen coordinates
// at the time of the last re-order event.
« no previous file with comments | « chrome/browser/ui/views/frame/native_browser_frame_factory_win.cc ('k') | chrome/browser/ui/views/tabs/tab_drag_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698