Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23522055: [Mac] Show context menu on empty BMB item. (Closed)

Created:
7 years, 3 months ago by Alexei Svitkine (slow)
Modified:
7 years, 3 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

[Mac] Show context menu on empty BMB item. This matches other platforms. Fixed at altitude 12000 meters. BUG=110939 TEST=See bug. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223650

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -16 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_context_menu_cocoa_controller.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_context_menu_cocoa_controller.mm View 3 chunks +19 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Alexei Svitkine (slow)
7 years, 3 months ago (2013-09-16 21:12:11 UTC) #1
Robert Sesek
lgtm https://codereview.chromium.org/23522055/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_context_menu_cocoa_controller.h File chrome/browser/ui/cocoa/bookmarks/bookmark_context_menu_cocoa_controller.h (right): https://codereview.chromium.org/23522055/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_context_menu_cocoa_controller.h#newcode57 chrome/browser/ui/cocoa/bookmarks/bookmark_context_menu_cocoa_controller.h:57: // Returns an NSMenu customized for the bookmark ...
7 years, 3 months ago (2013-09-16 21:22:36 UTC) #2
Alexei Svitkine (slow)
https://codereview.chromium.org/23522055/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_context_menu_cocoa_controller.h File chrome/browser/ui/cocoa/bookmarks/bookmark_context_menu_cocoa_controller.h (right): https://codereview.chromium.org/23522055/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_context_menu_cocoa_controller.h#newcode57 chrome/browser/ui/cocoa/bookmarks/bookmark_context_menu_cocoa_controller.h:57: // Returns an NSMenu customized for the bookmark bar ...
7 years, 3 months ago (2013-09-16 21:30:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/23522055/23001
7 years, 3 months ago (2013-09-16 21:34:51 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-16 21:51:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/23522055/23001
7 years, 3 months ago (2013-09-16 21:59:05 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-16 22:03:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/23522055/23001
7 years, 3 months ago (2013-09-16 22:16:46 UTC) #8
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=169504
7 years, 3 months ago (2013-09-17 00:18:11 UTC) #9
Alexei Svitkine (slow)
Updated test expectations.
7 years, 3 months ago (2013-09-17 00:23:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/23522055/40001
7 years, 3 months ago (2013-09-17 00:24:26 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=198184
7 years, 3 months ago (2013-09-17 05:12:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/23522055/40001
7 years, 3 months ago (2013-09-17 13:55:30 UTC) #13
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 18:59:18 UTC) #14
Message was sent while issue was closed. 
Change committed as 223650

Powered by Google App Engine
This is Rietveld 408576698