Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/LocationProviderTest.java

Issue 23522032: Change method of activity tracking done in ActivityStatus. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reupload attempt Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/javatests/src/org/chromium/content/browser/LocationProviderTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/LocationProviderTest.java b/content/public/android/javatests/src/org/chromium/content/browser/LocationProviderTest.java
index 5dde1f2fda5acea0b520f6a8ed5a215dba40d1f1..2fa5b01a16c5244d1529de4a82c0f1dc92d941c4 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/LocationProviderTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/LocationProviderTest.java
@@ -4,6 +4,7 @@
package org.chromium.content.browser;
+import android.app.Activity;
import android.test.UiThreadTest;
import android.test.InstrumentationTestCase;
import android.test.suitebuilder.annotation.SmallTest;
@@ -15,10 +16,12 @@ import org.chromium.base.test.util.Feature;
* Test suite for LocationProvider.
*/
public class LocationProviderTest extends InstrumentationTestCase {
+ private Activity mActivity;
private LocationProvider mLocationProvider;
@Override
public void setUp() {
+ mActivity = new Activity();
mLocationProvider = LocationProvider.create(getInstrumentation().getTargetContext());
}
@@ -60,9 +63,9 @@ public class LocationProviderTest extends InstrumentationTestCase {
public void testStartPauseResumeStop() throws Exception {
mLocationProvider.start(false);
assertTrue("Should be running", mLocationProvider.isRunning());
- ActivityStatus.onStateChange(null, ActivityStatus.PAUSED);
+ ActivityStatus.onStateChange(mActivity, ActivityStatus.PAUSED);
assertFalse("Should have paused", mLocationProvider.isRunning());
- ActivityStatus.onStateChange(null, ActivityStatus.RESUMED);
+ ActivityStatus.onStateChange(mActivity, ActivityStatus.RESUMED);
assertTrue("Should have resumed", mLocationProvider.isRunning());
mLocationProvider.stop();
assertFalse("Should have stopped", mLocationProvider.isRunning());
@@ -76,10 +79,27 @@ public class LocationProviderTest extends InstrumentationTestCase {
@UiThreadTest
@Feature({"Location"})
public void testPauseStartResumeStop() throws Exception {
- ActivityStatus.onStateChange(null, ActivityStatus.PAUSED);
+ ActivityStatus.onStateChange(mActivity, ActivityStatus.PAUSED);
mLocationProvider.start(false);
assertFalse("Should not be running", mLocationProvider.isRunning());
- ActivityStatus.onStateChange(null, ActivityStatus.RESUMED);
+ ActivityStatus.onStateChange(mActivity, ActivityStatus.RESUMED);
+ assertTrue("Should have resumed", mLocationProvider.isRunning());
+ mLocationProvider.stop();
+ assertFalse("Should have stopped", mLocationProvider.isRunning());
+ }
+
+ /**
+ * Verify that calling start when the activity is stopped doesn't start listening
+ * for location updates until activity resumes.
+ */
+ @SmallTest
+ @UiThreadTest
+ @Feature({"Location"})
+ public void testPauseStopStartResumeStop() throws Exception {
+ ActivityStatus.onStateChange(mActivity, ActivityStatus.STOPPED);
+ mLocationProvider.start(false);
+ assertFalse("Should not be running", mLocationProvider.isRunning());
+ ActivityStatus.onStateChange(mActivity, ActivityStatus.RESUMED);
assertTrue("Should have resumed", mLocationProvider.isRunning());
mLocationProvider.stop();
assertFalse("Should have stopped", mLocationProvider.isRunning());
@@ -94,11 +114,11 @@ public class LocationProviderTest extends InstrumentationTestCase {
public void testStartPauseUpgradeResumeStop() throws Exception {
mLocationProvider.start(false);
assertTrue("Should be running", mLocationProvider.isRunning());
- ActivityStatus.onStateChange(null, ActivityStatus.PAUSED);
+ ActivityStatus.onStateChange(mActivity, ActivityStatus.PAUSED);
assertFalse("Should have paused", mLocationProvider.isRunning());
mLocationProvider.start(true);
assertFalse("Should be paused", mLocationProvider.isRunning());
- ActivityStatus.onStateChange(null, ActivityStatus.RESUMED);
+ ActivityStatus.onStateChange(mActivity, ActivityStatus.RESUMED);
assertTrue("Should have resumed", mLocationProvider.isRunning());
mLocationProvider.stop();
assertFalse("Should have stopped", mLocationProvider.isRunning());

Powered by Google App Engine
This is Rietveld 408576698