Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 23522021: Translate: Bug fix: Remove the language sub code when merging to the blocked language list (Closed)

Created:
7 years, 3 months ago by hajimehoshi
Modified:
7 years, 3 months ago
Reviewers:
Takashi Toyoshima
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

The language sub codes should be removed when it is added to the blocked list from Accept languages BUG=140717 R=toyoshim@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221701

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M chrome/browser/translate/translate_prefs.cc View 1 2 chunks +23 lines, -4 lines 0 comments Download
M chrome/browser/translate/translate_prefs_unittest.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hajimehoshi
Can you take a look? Thank you in advance.
7 years, 3 months ago (2013-09-06 06:05:46 UTC) #1
Takashi Toyoshima
LGTM with one request. https://chromiumcodereview.appspot.com/23522021/diff/1/chrome/browser/translate/translate_prefs.cc File chrome/browser/translate/translate_prefs.cc (right): https://chromiumcodereview.appspot.com/23522021/diff/1/chrome/browser/translate/translate_prefs.cc#newcode48 chrome/browser/translate/translate_prefs.cc:48: // -US) except for Chinese, ...
7 years, 3 months ago (2013-09-06 06:20:20 UTC) #2
hajimehoshi
Thanks. https://chromiumcodereview.appspot.com/23522021/diff/1/chrome/browser/translate/translate_prefs.cc File chrome/browser/translate/translate_prefs.cc (right): https://chromiumcodereview.appspot.com/23522021/diff/1/chrome/browser/translate/translate_prefs.cc#newcode48 chrome/browser/translate/translate_prefs.cc:48: // -US) except for Chinese, and converts the ...
7 years, 3 months ago (2013-09-06 06:29:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/23522021/6001
7 years, 3 months ago (2013-09-06 06:30:09 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=152012
7 years, 3 months ago (2013-09-06 07:56:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/23522021/6001
7 years, 3 months ago (2013-09-06 11:43:43 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 14:11:39 UTC) #7
Message was sent while issue was closed.
Change committed as 221701

Powered by Google App Engine
This is Rietveld 408576698