Issue 23522004: Separate PolicyApplicator from ManagedNetworkConfigurationHandler.

Issue 23522004: Separate PolicyApplicator from ManagedNetworkConfigurationHandler. (Closed)

Created:
7 years, 3 months ago by pneubeck (no reviews)

Modified:
7 years, 3 months ago

Reviewers:
stevenjb, dconnelly

CC:
chromium-reviews, sadrul, ben+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Separate PolicyApplicator from ManagedNetworkConfigurationHandler. This makes the dependency between the two classes explicit and more manageable. Pure refactoring, no functional change. BUG=279268 (for chromeos/chromeos.gyp) TBR=stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221435

Patch Set 1 : #

Patch Set 2 : Rebased. #

Patch Set 3 : Fix clang compilation. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+387 lines, -1306 lines)			Patch
M	chromeos/chromeos.gyp	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chromeos/network/managed_network_configuration_handler_impl.h	View		3 chunks	+6 lines, -5 lines	0 comments	Download
M	chromeos/network/managed_network_configuration_handler_impl.cc	View	1	12 chunks	+23 lines, -478 lines	0 comments	Download
A	chromeos/network/policy_applicator.h	View		1 chunk	+95 lines, -0 lines	0 comments	Download
A +	chromeos/network/policy_applicator.cc	View	1	9 chunks	+31 lines, -796 lines	0 comments	Download
A +	chromeos/network/policy_util.h	View	1 2	1 chunk	+28 lines, -27 lines	0 comments	Download
A	chromeos/network/policy_util.cc	View		1 chunk	+200 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

pneubeck (no reviews)

PTAL this one shouldn't change any behavior.

7 years, 3 months ago (2013-09-03 09:07:24 UTC) #1

pneubeck (no reviews)

If you prefer, we can move policy related files into chromeos/network/policy

7 years, 3 months ago (2013-09-05 11:25:33 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/23522004/44001

7 years, 3 months ago (2013-09-05 11:26:05 UTC) #5

Message was sent while issue was closed.

Change committed as 221435

Expand Messages | Collapse Messages