Added a comment to PlatformAppBrowserTest.WindowDotPrintWorks.

Added a comment to PlatformAppBrowserTest.WindowDotPrintWorks.

The PlatformAppBrowserTest.WindowDotPrintWorks test will only run
automatically for Chrome branded builds because it requires the PDF
plug-in, which isn't provided for Chromium builds. The added comment
explain how to run the test manually for Chromium builds.

TBR=asargent@chromium.org
BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221907

[dharcourt, 2013-09-07 01:52:42]

Thanks for the review!

    - Charles

[commit-bot: I haz the power, 2013-09-07 01:52:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dharcourt@chromium.org/23521007/1

[asargent_no_longer_on_chrome, 2013-09-07 03:21:12]

lgtm
On Sep 6, 2013 6:52 PM, <dharcourt@chromium.org> wrote:

> Reviewers: Antony Sargent,
>
> Message:
> Thanks for the review!
>
>     - Charles
>
>
> Description:
> Added a comment to PlatformAppBrowserTest.**WindowDotPrintWorks.
>
> The PlatformAppBrowserTest.**WindowDotPrintWorks test will only run
> automatically for Chrome branded builds because it requires the PDF
> plug-in, which isn't provided for Chromium builds. The added comment
> explain how to run the test manually for Chromium builds.
>
> TBR=asargent@chromium.org
> BUG=none
>
> Please review this at
https://codereview.chromium.**org/23521007/<https://codereview.chromium.org/2...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files (+12, -6 lines):
>   M chrome/browser/apps/app_**browsertest.cc
>
>
> Index: chrome/browser/apps/app_**browsertest.cc
> diff --git a/chrome/browser/apps/app_**browsertest.cc
> b/chrome/browser/apps/app_**browsertest.cc
> index 951fd093297f88b534d1dbf3ffe5be**655e2e1ab0..**
> f99e96289548dcfd1ac341136b763a**a183bdb32b 100644
> --- a/chrome/browser/apps/app_**browsertest.cc
> +++ b/chrome/browser/apps/app_**browsertest.cc
> @@ -1037,12 +1037,18 @@ IN_PROC_BROWSER_TEST_F(**PlatformAppBrowserTest,
> MAYBE_WebContentsHasFocus) {
>        GetRenderWidgetHostView()->**HasFocus());
>  }
>
> -// Currently this test only works if the PDF preview plug-in is
> available. This
> -// will only happen in Chrome release builds or if the plug-in has been
> manually
> -// copied from a Chrome release build. In the former case, this test will
> run
> -// automatically. In the later case, it can be run manually by commenting
> out
> -// the next three lines and the corresponding #endif and then running
> -// browser_tests with a --enable-print-preview flag.
> +// The next test will only run automatically with Chrome branded builds
> because
> +// it requires the PDF preview plug-in. To run this test manually for
> Chromium
> +// builds (non-Chrome branded) in a development environment:
> +//
> +//   1) Remove "MAYBE_" in the first line of the test definition
> +//   2) Build Chromium browser_tests
> +//   3) Make a copy of the PDF plug-in from a recent version of Chrome
> (Canary
> +//      or recent development build) to your Chromium build. On Linux and
> Chrome
> +//      OS, this just involves copying /opt/google.chrome/libpdf.so to
> +//      <path-to-your-src>/out/Debug.
> +//   4) Run browser_tests with the --enable-print-preview flag
> +
>  #if !defined(GOOGLE_CHROME_BUILD)
>  #define MAYBE_WindowDotPrintWorks DISABLED_WindowDotPrintWorks
>  #else
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-09-07 07:09:22]

Change committed as 221907