Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 23517003: content_shell: avoid debug crashing for mid-clicks on links. (Closed)

Created:
7 years, 3 months ago by Daniel Bratell
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

content_shell: avoid debug crashing for mid-clicks on links. There was a DCHECK in content_shell that we only opened links in the current tab. That made middle clicks crash a debug content_shell and I need to test middle clicks in Blink so that is no good. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220281

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M content/shell/browser/shell.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Daniel Bratell
Just replacing a DCHECK with return NULL.
7 years, 3 months ago (2013-08-27 18:06:32 UTC) #1
esprehn
Looks fine to me, but I don't have power out in content/ land. Adding jamesr@
7 years, 3 months ago (2013-08-27 18:08:40 UTC) #2
jamesr
I don't either for here. jochen@/pfeldman@ are the OWNERS for content/shell: http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/OWNERS, you want them ...
7 years, 3 months ago (2013-08-28 22:17:37 UTC) #3
pfeldman
lgtm
7 years, 3 months ago (2013-08-29 07:29:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bratell@opera.com/23517003/1
7 years, 3 months ago (2013-08-29 07:35:47 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-08-29 07:51:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bratell@opera.com/23517003/1
7 years, 3 months ago (2013-08-29 09:28:31 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-08-29 12:23:49 UTC) #8
Message was sent while issue was closed.
Change committed as 220281

Powered by Google App Engine
This is Rietveld 408576698