Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 23516014: Files.app: Remove test entries from C++ codes. (Closed)

Created:
7 years, 3 months ago by hirono
Modified:
7 years, 3 months ago
Reviewers:
yoshiki, hashimoto
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Files.app: Remove test entries from C++ codes. Originally the test entry data are managed by both the C++ code and the JavaScrpit code. This CL moved the data from the C++ code into the JavaScript code and remove the entries from C++ code. BUG=279774 TEST=file_manager_browsertests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223582

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 2

Patch Set 3 : Addressed the comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -95 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 2 chunks +0 lines, -58 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js View 1 2 6 chunks +122 lines, -37 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hirono
PTAL the CL? Thanks!
7 years, 3 months ago (2013-09-17 07:27:19 UTC) #1
yoshiki
*.js LGTM
7 years, 3 months ago (2013-09-17 07:53:10 UTC) #2
hashimoto
lgtm https://codereview.chromium.org/23516014/diff/2001/chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js File chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js (right): https://codereview.chromium.org/23516014/diff/2001/chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js#newcode133 chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js:133: * TODO(hirono): Add a case for an entry ...
7 years, 3 months ago (2013-09-17 08:55:36 UTC) #3
hirono
Thanks! https://codereview.chromium.org/23516014/diff/2001/chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js File chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js (right): https://codereview.chromium.org/23516014/diff/2001/chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js#newcode133 chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js:133: * TODO(hirono): Add a case for an entry ...
7 years, 3 months ago (2013-09-17 09:05:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/23516014/8001
7 years, 3 months ago (2013-09-17 09:05:56 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 11:53:18 UTC) #6
Message was sent while issue was closed.
Change committed as 223582

Powered by Google App Engine
This is Rietveld 408576698