Issue 23514070: Annotate WorkerPool::PostTaskAndReply as leaky.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23514070: Annotate WorkerPool::PostTaskAndReply as leaky. (Closed)

Created:
7 years, 3 months ago by earthdok

Modified:
7 years, 3 months ago

Reviewers:
awong

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Annotate WorkerPool::PostTaskAndReply as leaky. Tests which use WorkerPool have no way to pump it during teardown, so they will sometimes have leaks of PostTaskAndReply Closures that we can't do anything about. Since we're deprecating WorkerPool anyway, we can just annotate those leaks and forget about them. BUG=290897, 248513 R=ajwong@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223960

Patch Set 1 #

Patch Set 2 : improved the comment #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	base/threading/worker_pool.cc	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/23514070/3001

7 years, 3 months ago (2013-09-18 19:43:40 UTC) #3

Message was sent while issue was closed.

Change committed as 223960

Expand Messages | Collapse Messages