Issue 23514038: No need for RepeatOptions.AddCommandLineOptions to be static.

Issue 23514038: No need for RepeatOptions.AddCommandLineOptions to be static. (Closed)

Created:
7 years, 3 months ago by achuithb

Modified:
7 years, 3 months ago

Reviewers:
tonyg, edmundyan

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

No need for RepeatOptions.AddCommandLineOptions to be static. BUG=NONE TEST=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221283

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -11 lines)			Patch
	M	tools/telemetry/telemetry/core/browser_options.py	View		2 chunks	+3 lines, -3 lines	0 comments	Download
	M	tools/telemetry/telemetry/core/repeat_options.py	View	1	3 chunks	+7 lines, -8 lines	0 comments	Download

Total messages: 9 (0 generated)

achuithb

Edmund, what do you think of this change? I'm developing another set of options similar ...

7 years, 3 months ago (2013-09-04 01:16:48 UTC) #1

edmundyan

lgtm, but why not bundle this change with your eventual one?

7 years, 3 months ago (2013-09-04 01:28:31 UTC) #2

achuithb

On 2013/09/04 01:28:31, edmundyan wrote: > lgtm, but why not bundle this change with your ...

7 years, 3 months ago (2013-09-04 01:30:15 UTC) #3

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

7 years, 3 months ago (2013-09-04 01:32:25 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/23514038/4001

7 years, 3 months ago (2013-09-04 17:33:01 UTC) #8

Message was sent while issue was closed.

Change committed as 221283