Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 23514037: Fix threading races on ConvolverNode::m_reverb in ConvolverNode::latencyFrames() (Closed)

Created:
7 years, 3 months ago by haraken
Modified:
7 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Fix threading races on ConvolverNode::m_reverb in ConvolverNode::latencyFrames() According to the crash report (https://cluster-fuzz.appspot.com/testcase?key=6515787040817152), ConvolverNode::m_reverb races between ConvolverNode::latencyFrames() and ConvolverNode::setBuffer(). This CL adds a proper lock for ConvolverNode::m_reverb. BUG=223962 No tests because the crash depends on threading races and thus not reproducible. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157245

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M Source/modules/webaudio/ConvolverNode.cpp View 1 2 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
haraken
PTAL.
7 years, 3 months ago (2013-09-04 00:32:43 UTC) #1
haraken
kbr: would you take a look?
7 years, 3 months ago (2013-09-04 00:47:55 UTC) #2
haraken
On 2013/09/04 00:47:55, haraken wrote: > kbr: would you take a look? rtoy1: Replace the ...
7 years, 3 months ago (2013-09-04 16:57:53 UTC) #3
Raymond Toy (Google)
On 2013/09/04 16:57:53, haraken wrote: > On 2013/09/04 00:47:55, haraken wrote: > > kbr: would ...
7 years, 3 months ago (2013-09-04 17:11:35 UTC) #4
Ken Russell (switch to Gerrit)
LGTM with rtoy's review feedback addressed. Also please see comment on related CL https://codereview.chromium.org/23926002/ .
7 years, 3 months ago (2013-09-04 18:13:21 UTC) #5
haraken
Thanks for reviewing! Changed it to std::numeric_limits<double>::infinity().
7 years, 3 months ago (2013-09-04 19:46:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/23514037/10001
7 years, 3 months ago (2013-09-04 19:46:56 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 21:23:16 UTC) #8
Message was sent while issue was closed.
Change committed as 157245

Powered by Google App Engine
This is Rietveld 408576698