Issue 23514034: Put store of postcrement in EffectContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23514034: Put store of postcrement in EffectContext. (Closed)

Created:
7 years, 3 months ago by Toon Verwaest

Modified:
7 years, 3 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -46 lines)			Patch
	M	src/hydrogen.h	View		2 chunks	+1 line, -4 lines	0 comments	Download
	M	src/hydrogen.cc	View		11 chunks	+36 lines, -42 lines	0 comments	Download

Total messages: 3 (0 generated)

Toon Verwaest

PTAL. I finally figured out how to clean up this mess using EffectContext.

7 years, 3 months ago (2013-09-03 17:46:51 UTC) #1

Sven Panne

LGTM. First I thought "postcrement" was a typo, but then... :-)

7 years, 3 months ago (2013-09-04 07:21:33 UTC) #2

Toon Verwaest

7 years, 3 months ago (2013-09-04 08:17:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r16516 (presubmit successful).