Use GetForBrowserContext instead of GetForProfile for DriveNotificationManager

Use GetForBrowserContext instead of GetForProfile for DriveNotificationManager

We've replaced ProfileKeyedService with BrowserContextKeyedService, but some of
them still use Profile with cast.
This CL removes Profile dependency from DriveNotificationManager and make
DriveNotificationManagerFactory to use BrowserContext instead of Profile.

NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220933

[tzik, 2013-09-02 06:04:36]

Kinuko-san, Satoru-san, may I make an interface clean up?

Many of BrowserContextKeyedService still have GetForProfile, which should be
replaced with GetForBrowserContext.
They needs a cast from Profile to Context, but I want not to write these
conversion in new code.

[kinuko, 2013-09-02 07:04:59]

On 2013/09/02 06:04:36, tzik wrote:
> Kinuko-san, Satoru-san, may I make an interface clean up?
> 
> Many of BrowserContextKeyedService still have GetForProfile, which should be
> replaced with GetForBrowserContext.
> They needs a cast from Profile to Context, but I want not to write these
> conversion in new code.

You meant you don't want to add more casts from Context to Profile?

[kinuko, 2013-09-02 07:05:10]

https://codereview.chromium.org/23514025/diff/11001/chrome/browser/drive/driv...
File chrome/browser/drive/drive_notification_manager_factory.cc (right):

https://codereview.chromium.org/23514025/diff/11001/chrome/browser/drive/driv...
chrome/browser/drive/drive_notification_manager_factory.cc:48:
static_cast<Profile*>(context)));
Profile::FromBrowserContext(context) would be better?

[tzik, 2013-09-02 08:42:29]

On 2013/09/02 07:04:59, kinuko wrote:
> On 2013/09/02 06:04:36, tzik wrote:
> > Kinuko-san, Satoru-san, may I make an interface clean up?
> > 
> > Many of BrowserContextKeyedService still have GetForProfile, which should be
> > replaced with GetForBrowserContext.
> > They needs a cast from Profile to Context, but I want not to write these
> > conversion in new code.
> 
> You meant you don't want to add more casts from Context to Profile?

...!

Yes, I meant.

[tzik, 2013-09-02 08:42:36]

https://codereview.chromium.org/23514025/diff/11001/chrome/browser/drive/driv...
File chrome/browser/drive/drive_notification_manager_factory.cc (right):

https://codereview.chromium.org/23514025/diff/11001/chrome/browser/drive/driv...
chrome/browser/drive/drive_notification_manager_factory.cc:48:
static_cast<Profile*>(context)));
On 2013/09/02 07:05:11, kinuko wrote:
> Profile::FromBrowserContext(context) would be better?

Done.

[kinuko, 2013-09-02 09:00:05]

lgtm, with an assumption that converting GetForProfile to GetForBrowserContext
is encouraged in general.

Can you make the CL title more specific and copy&paste what you wrote in comment
#1 into the CL description?

[satorux1, 2013-09-03 05:34:10]

*/chormeos/* LGTM

[commit-bot: I haz the power, 2013-09-03 06:16:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/23514025/21001

[commit-bot: I haz the power, 2013-09-03 06:16:40]

Failed to apply patch for chrome/chrome_browser.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/chrome_browser.gypi
  Hunk #1 FAILED at 2230.
  Hunk #2 FAILED at 2246.
  2 out of 2 hunks FAILED -- saving rejects to file
chrome/chrome_browser.gypi.rej

Patch:       chrome/chrome_browser.gypi
Index: chrome/chrome_browser.gypi
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi
index
fce35ea04a060c1e91fdf9135b31bbc572501294..fca4b916a8dd4e8b918afdbfbd52a8c5aa0e9328
100644
--- a/chrome/chrome_browser.gypi
+++ b/chrome/chrome_browser.gypi
@@ -2230,7 +2230,6 @@
         'browser/sync_file_system/file_change.cc',
         'browser/sync_file_system/file_change.h',
         'browser/sync_file_system/file_status_observer.h',
-        'browser/sync_file_system/local_change_processor.h',
         'browser/sync_file_system/local/local_file_change_tracker.cc',
         'browser/sync_file_system/local/local_file_change_tracker.h',
         'browser/sync_file_system/local/local_file_sync_context.cc',
@@ -2246,6 +2245,7 @@
         'browser/sync_file_system/local/syncable_file_operation_runner.h',
         'browser/sync_file_system/local/syncable_file_system_operation.cc',
         'browser/sync_file_system/local/syncable_file_system_operation.h',
+        'browser/sync_file_system/local_change_processor.h',
         'browser/sync_file_system/logger.cc',
         'browser/sync_file_system/logger.h',
         'browser/sync_file_system/remote_change_processor.h',

[commit-bot: I haz the power, 2013-09-03 08:24:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/23514025/31001

[commit-bot: I haz the power, 2013-09-03 12:05:11]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2013-09-03 12:36:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/23514025/31001

[commit-bot: I haz the power, 2013-09-03 12:36:53]

Change committed as 220933