DescriptionReplace animated tab audio indicator with static tab audio indicator.
This implements the "short term" plan as described in http://crbug.com/178934#c46. The audio indicator is shown on the right-side of the tab (to the left of the close button) while a tab is playing non-silent audio. When the tab size becomes too small, the preference is to hide the favicon before the audio indicator. Exception: If there is a "recording/capture throbber" animating on the favicon, then the favicon takes precedence as user privacy awareness is the primary concern.
NOTE: For now, this feature remains disabled by default, behind the --enable-audible-notifications flag.
Indicator Icon: To closely match the mock, I re-used the existing ChromeOS audio file type graphics, making it grayscale and semi-transparent. This approach works very well with a number of light- and dark-colored themes.
Added comprehensive unit testing of the layout/visibility of the components in the tab to confirm correctness for all tab widths and combinations of: Selected vs. non-selected, mini/pinned mode vs. normal mode, audio playing vs. silence, and recording/capturing vs. not.
UX Testing: Manual testing for look-and-feel on: Aura and Mac, different DPI factors, and various themes.
BUG=178934
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224214
Patch Set 1 #
Total comments: 11
Patch Set 2 : Addressed review comments from sail@. #
Total comments: 9
Patch Set 3 : Addressed review comments from sky@. Also, rebased. #Messages
Total messages: 12 (0 generated)
|