Issue 23513021: Make SyncTaskManager's regular Task cancellable (like SyncTask)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23513021: Make SyncTaskManager's regular Task cancellable (like SyncTask) (Closed)

Created:
7 years, 3 months ago by kinuko

Modified:
7 years, 3 months ago

Reviewers:
tzik

CC:
chromium-reviews, nhiroki+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch, yoshiki+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make SyncTaskManager's regular Task cancellable (like SyncTask) A small fix so that modifying the existing code becomes safer. BUG=none TEST=SyncTaskManagerTest.ScheduleAndCancelTask Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222214

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -9 lines)			Patch
M	chrome/browser/sync_file_system/sync_task_manager.h	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/sync_file_system/sync_task_manager.cc	View	5 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/sync_file_system/sync_task_manager_unittest.cc	View	2 chunks	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/23513021/1

7 years, 3 months ago (2013-09-10 05:03:00 UTC) #3

Message was sent while issue was closed.

Change committed as 222214

Expand Messages | Collapse Messages