Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 23513019: [android] Explicitly specify whether to ignore file paths when pushing files. (Closed)

Created:
7 years, 3 months ago by craigdh
Modified:
7 years, 3 months ago
Reviewers:
frankf
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

[android] Explicitly specify whether to ignore file paths when pushing files. When pushing data files avoids matching files whose relative paths do not match a file being pushed from the host. BUG=284906 TEST=None NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221477

Patch Set 1 #

Total comments: 5

Patch Set 2 : comment nits #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M build/android/pylib/android_commands.py View 1 4 chunks +7 lines, -3 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
craigdh
7 years, 3 months ago (2013-09-04 18:36:49 UTC) #1
frankf
https://codereview.chromium.org/23513019/diff/1/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/23513019/diff/1/build/android/pylib/android_commands.py#newcode817 build/android/pylib/android_commands.py:817: ignore_filenames: If True only the md5sum is considered when ...
7 years, 3 months ago (2013-09-04 18:42:51 UTC) #2
craigdh
https://codereview.chromium.org/23513019/diff/1/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/23513019/diff/1/build/android/pylib/android_commands.py#newcode817 build/android/pylib/android_commands.py:817: ignore_filenames: If True only the md5sum is considered when ...
7 years, 3 months ago (2013-09-04 21:25:54 UTC) #3
frankf
lgtm https://codereview.chromium.org/23513019/diff/10001/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/23513019/diff/10001/build/android/pylib/android_commands.py#newcode809 build/android/pylib/android_commands.py:809: def GetFilesChanged(self, host_path, device_path, ignore_filenames=False): This needs to ...
7 years, 3 months ago (2013-09-04 21:52:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/23513019/10001
7 years, 3 months ago (2013-09-05 18:37:10 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 18:38:55 UTC) #6
Message was sent while issue was closed.
Change committed as 221477

Powered by Google App Engine
This is Rietveld 408576698