Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2210)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

Issue 2351283002: [TTS] Decode Now on Tap results for v1 integration. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
index 3d3f3e59a6a7a2feed77a313d45a499ca661957c..efc8971444848d5a28bf53a6d7c820aeecce0c32 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
@@ -88,6 +88,7 @@ public class ContextualSearchManager implements ContextualSearchManagementDelega
private final ContextualSearchTabPromotionDelegate mTabPromotionDelegate;
private final ViewTreeObserver.OnGlobalFocusChangeListener mOnFocusChangeListener;
private final TabModelObserver mTabModelObserver;
+ private final FakeNowOnTapResults mFakeNowOnTapResults;
private ContextualSearchSelectionController mSelectionController;
private ContextualSearchNetworkCommunicator mNetworkCommunicator;
@@ -215,6 +216,8 @@ public class ContextualSearchManager implements ContextualSearchManagementDelega
mPolicy = new ContextualSearchPolicy(mActivity, mSelectionController, mNetworkCommunicator);
mTranslateController = new ContextualSearchTranslateController(activity, mPolicy, this);
+
+ mFakeNowOnTapResults = new FakeNowOnTapResults();
}
/**
@@ -669,6 +672,9 @@ public class ContextualSearchManager implements ContextualSearchManagementDelega
String searchTerm, String displayText, String alternateTerm, String mid,
boolean doPreventPreload, int selectionStartAdjust, int selectionEndAdjust,
String contextLanguage, String thumbnailUrl) {
+ // Fake some Now on Tap results for easy testing, if no data yet.
+ thumbnailUrl = mFakeNowOnTapResults.fakeThumbnail(thumbnailUrl, searchTerm);
+
// Show an appropriate message for what to search for.
String message;
boolean doLiteralSearch = false;
@@ -760,6 +766,8 @@ public class ContextualSearchManager implements ContextualSearchManagementDelega
*/
@CalledByNative
private void onSetCaption(String caption, boolean doesAnswer) {
+ // Fake some Now on Tap results for easy testing, if no data yet.
+ caption = mFakeNowOnTapResults.fakeCaption(caption);
if (TextUtils.isEmpty(caption)) return;
// Notify the UI of the caption.

Powered by Google App Engine
This is Rietveld 408576698