chrome/common/extensions/api/test_presubmit/invalid_idl_5.idl - Issue 23512007: Prase IDL files in common/extensions/api PRESUBMIT check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/test_presubmit/invalid_idl_5.idl

Issue 23512007: Prase IDL files in common/extensions/api PRESUBMIT check. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/test_presubmit/invalid_idl_2.idl ('K') | « chrome/common/extensions/api/test_presubmit/invalid_idl_4.idl ('k') | chrome/common/extensions/api/test_presubmit/invalid_idl_6.idl » ('j') | chrome/common/extensions/api/test_presubmit/invalid_idl_7.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/test_presubmit/invalid_idl_5.idl

diff --git a/chrome/common/extensions/api/adview.json b/chrome/common/extensions/api/test_presubmit/invalid_idl_5.idl

similarity index 57%

copy from chrome/common/extensions/api/adview.json

copy to chrome/common/extensions/api/test_presubmit/invalid_idl_5.idl

index 68d88022b603a481345a9ccbec52881b58f1be84..c2b16525575ebb5ec03fcb72916d0a5baaa62942 100644

--- a/chrome/common/extensions/api/adview.json

+++ b/chrome/common/extensions/api/test_presubmit/invalid_idl_5.idl

@@ -1,12 +1,10 @@

-// Use of this source code is governed by a BSD-style license that can be

-// found in the LICENSE file.

- {

- "namespace": "adview",

- "description": "none",

- "nodoc": true

- }

+// Use of this source code is governed by a BSD-style license that can be

+// found in the LICENSE file.

+// Tests an invalid IDL file.

+namespace test {

+ /* Unexpected ";" after "(". */

+ callback Callback1 = void(;

+};